feat: allow timeout to be configurable (#16)

Author: eh-am

README.md

@@ -29,6 +29,7 @@ For a complete list of variables check the section below.
 | `PYROSCOPE_AUTH_TOKEN`     | `""`                             | authorization key (token authentication)       |
 | `PYROSCOPE_SELF_PROFILING` | `false`                          | whether to profile the extension itself or not |
 | `PYROSCOPE_LOG_LEVEL`      | `info`                           | `error` or `info` or `debug` or `trace`        |
+| `PYROSCOPE_TIMEOUT`        | `10s`                            | http client timeout ([go duration format](https://pkg.go.dev/time#Duration))      |
 
 # How it works
 The profiler will run as normal, and periodically will send data to the relay server (the server running at `http://localhost:4040`).

main.go

@@ -10,6 +10,7 @@ import (
 	"path/filepath"
 	"strconv"
 	"syscall"
+	"time"
 
 	"github.com/pyroscope-io/pyroscope-lambda-extension/extension"
 	"github.com/pyroscope-io/pyroscope-lambda-extension/relay"
@@ -31,6 +32,7 @@ var (
 	remoteAddress = getEnvStrOr("PYROSCOPE_REMOTE_ADDRESS", "https://ingest.pyroscope.cloud")
 
 	authToken = getEnvStrOr("PYROSCOPE_AUTH_TOKEN", "")
+	timeout   = getEnvDurationOr("PYROSCOPE_TIMEOUT", time.Second*10)
 
 	// profile the extension?
 	selfProfiling = getEnvBool("PYROSCOPE_SELF_PROFILING")
@@ -41,7 +43,7 @@ func main() {
 	ctx, cancel := context.WithCancel(context.Background())
 
 	// Init components
-	remoteClient := relay.NewRemoteClient(logger, &relay.RemoteClientCfg{Address: remoteAddress, AuthToken: authToken})
+	remoteClient := relay.NewRemoteClient(logger, &relay.RemoteClientCfg{Address: remoteAddress, AuthToken: authToken, Timeout: timeout})
 	// TODO(eh-am): a find a better default for num of workers
 	queue := relay.NewRemoteQueue(logger, &relay.RemoteQueueCfg{NumWorkers: 4}, remoteClient)
 	ctrl := relay.NewController(logger, queue)
@@ -168,3 +170,19 @@ func getEnvBool(key string) bool {
 
 	return v
 }
+
+func getEnvDurationOr(key string, fallback time.Duration) time.Duration {
+	k, ok := os.LookupEnv(key)
+
+	// has an explicit value
+	if ok && k != "" {
+		dur, err := time.ParseDuration(k)
+		if err != nil {
+			return fallback
+		}
+
+		return dur
+	}
+
+	return fallback
+}

relay/client.go

@@ -38,7 +38,6 @@ func NewRemoteClient(log *logrus.Entry, config *RemoteClientCfg) *RemoteClient {
 	return &RemoteClient{
 		log:    log,
 		config: config,
-		// TODO(eh-am): improve this client with timeouts and whatnot
 		client: &http.Client{
 			Timeout: timeout,
 		},