Skip to content

Commit 205163a

Browse files
authored
chore: use rbspy fork crate instead of submodule (#118)
1 parent 457bb15 commit 205163a

File tree

8 files changed

+130
-137
lines changed

8 files changed

+130
-137
lines changed

.drone/drone.yml

Lines changed: 1 addition & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -5,10 +5,6 @@ platform:
55
arch: amd64
66
os: linux
77
steps:
8-
- commands:
9-
- git submodule update --init --recursive
10-
image: alpine/git
11-
name: submodules
128
- commands:
139
- uname -a
1410
- make test
@@ -25,10 +21,6 @@ platform:
2521
arch: arm64
2622
os: linux
2723
steps:
28-
- commands:
29-
- git submodule update --init --recursive
30-
image: alpine/git
31-
name: submodules
3224
- commands:
3325
- uname -a
3426
- make test
@@ -40,6 +32,6 @@ trigger:
4032
type: docker
4133
---
4234
kind: signature
43-
hmac: f38ec1847fa65566c19f685da7928d2eb5cdc68295236e9a18080032a49edeca
35+
hmac: afb4cb757c4a553f765b97688bd67b2fe94528e404540d2cbd3c0683e4e0b0a0
4436

4537
...

.drone/pipelines/test.jsonnet

Lines changed: 0 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -8,11 +8,6 @@ local pipelines = import '../util/pipelines.jsonnet';
88
event: ['pull_request'],
99
},
1010
steps: [
11-
{
12-
name: 'submodules',
13-
image: 'alpine/git',
14-
commands: ['git submodule update --init --recursive'],
15-
},
1611
{
1712
name: 'make cli/test',
1813
image: build_image.linux,
@@ -25,11 +20,6 @@ local pipelines = import '../util/pipelines.jsonnet';
2520
event: ['pull_request'],
2621
},
2722
steps: [
28-
{
29-
name: 'submodules',
30-
image: 'alpine/git',
31-
commands: ['git submodule update --init --recursive'],
32-
},
3323
{
3424
name: 'make cli/test',
3525
image: build_image.linux,

Cargo.lock

Lines changed: 40 additions & 36 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

pyroscope_backends/pyroscope_rbspy/Cargo.toml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,7 @@ repository = "https://github.com/pyroscope-io/pyroscope-rs"
1414
readme = "README.md"
1515

1616
[dependencies]
17-
rbspy= {package = "rbspy", path="../rbspy"}
17+
pyroscope-rbspy-oncpu = { version="0.17.0" }
1818
pyroscope = { version = "0.5.5", path = "../../", default-features = false }
1919
thiserror ="1.0"
2020
log = "0.4"

pyroscope_backends/pyroscope_rbspy/src/lib.rs

Lines changed: 8 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,7 @@ use pyroscope::{
55
},
66
error::{PyroscopeError, Result},
77
};
8-
use rbspy::sampler::Sampler;
8+
use pyroscope_rbspy_oncpu::sampler::Sampler;
99
use std::{
1010
ops::Deref,
1111
sync::{
@@ -137,7 +137,7 @@ pub struct Rbspy {
137137
/// Rbspy Sampler
138138
sampler: Option<Sampler>,
139139
/// StackTrace Receiver
140-
//stack_receiver: Option<Receiver<rbspy::StackTrace>>,
140+
//stack_receiver: Option<Receiver<pyroscope_rbspy_oncpu::StackTrace>>,
141141
/// Error Receiver
142142
error_receiver: Option<Receiver<std::result::Result<(), anyhow::Error>>>,
143143
/// Profiling buffer
@@ -234,8 +234,8 @@ impl Backend for Rbspy {
234234

235235
// Channel for StackTraces generated by the RubySpy Sampler
236236
let (stack_sender, stack_receiver): (
237-
SyncSender<rbspy::StackTrace>,
238-
Receiver<rbspy::StackTrace>,
237+
SyncSender<pyroscope_rbspy_oncpu::StackTrace>,
238+
Receiver<pyroscope_rbspy_oncpu::StackTrace>,
239239
) = sync_channel(queue_size);
240240

241241
// Set Error and Stack Receivers
@@ -312,8 +312,8 @@ impl From<StackFrameWrapper> for StackFrame {
312312
}
313313
}
314314

315-
impl From<rbspy::StackFrame> for StackFrameWrapper {
316-
fn from(frame: rbspy::StackFrame) -> Self {
315+
impl From<pyroscope_rbspy_oncpu::StackFrame> for StackFrameWrapper {
316+
fn from(frame: pyroscope_rbspy_oncpu::StackFrame) -> Self {
317317
StackFrameWrapper(StackFrame {
318318
module: None,
319319
name: Some(frame.name),
@@ -333,8 +333,8 @@ impl From<StackTraceWrapper> for StackTrace {
333333
}
334334
}
335335

336-
impl From<(rbspy::StackTrace, &BackendConfig)> for StackTraceWrapper {
337-
fn from(arg: (rbspy::StackTrace, &BackendConfig)) -> Self {
336+
impl From<(pyroscope_rbspy_oncpu::StackTrace, &BackendConfig)> for StackTraceWrapper {
337+
fn from(arg: (pyroscope_rbspy_oncpu::StackTrace, &BackendConfig)) -> Self {
338338
let (trace, config) = arg;
339339

340340
StackTraceWrapper(StackTrace::new(

pyroscope_backends/rbspy

Submodule rbspy deleted from 3d81c2e

pyroscope_cli/Cargo.lock

Lines changed: 40 additions & 36 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

0 commit comments

Comments
 (0)