Skip to content

Commit 366441f

Browse files
authored
fix release workflows (#221)
1 parent 28ef29c commit 366441f

File tree

2 files changed

+23
-27
lines changed

2 files changed

+23
-27
lines changed

.github/workflows/publish.yml

Lines changed: 3 additions & 21 deletions
Original file line numberDiff line numberDiff line change
@@ -21,28 +21,10 @@ jobs:
2121
with:
2222
toolchain: 1.85.0
2323
- name: publish pyroscope crate
24-
continue-on-error: true
24+
continue-on-error: false
2525
run: |
2626
cargo login ${{ secrets.CARGO_TOKEN }}
2727
cargo publish
28-
# publish-cli:
29-
# name: pyroscope-cli
30-
# runs-on: ubuntu-latest
31-
# if: "startsWith(github.event.release.tag_name, 'cli-')"
32-
# steps:
33-
# - uses: actions/checkout@11bd71901bbe5b1630ceea73d27597364c9af683 # v4.2.2
34-
# with:
35-
# submodules: recursive
36-
# - uses: dtolnay/rust-toolchain@888c2e1ea69ab0d4330cbf0af1ecc7b68f368cc1
37-
# with:
38-
# toolchain: 1.82.0
39-
# - name: install libunwind (for pprof)
40-
# run: sudo apt install libunwind8-dev
41-
# - name: publish pyroscope crate
42-
# continue-on-error: true
43-
# run: |
44-
# cargo login ${{ secrets.CARGO_TOKEN }}
45-
# cargo publish --manifest-path pyroscope_cli/Cargo.toml
4628
publish-pprofrs:
4729
name: "Backend: pprofrs"
4830
runs-on: ubuntu-latest
@@ -72,7 +54,7 @@ jobs:
7254
with:
7355
toolchain: 1.85.0
7456
- name: publish rbspy crate
75-
continue-on-error: true
57+
continue-on-error: false
7658
run: |
7759
cargo login ${{ secrets.CARGO_TOKEN }}
7860
cargo publish --manifest-path pyroscope_backends/pyroscope_rbspy/Cargo.toml
@@ -88,7 +70,7 @@ jobs:
8870
with:
8971
toolchain: 1.85.0
9072
- name: publish pyspy crate
91-
continue-on-error: true
73+
continue-on-error: false
9274
run: |
9375
cargo login ${{ secrets.CARGO_TOKEN }}
9476
cargo publish --manifest-path pyroscope_backends/pyroscope_pyspy/Cargo.toml

.github/workflows/release.yml

Lines changed: 20 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,9 @@ jobs:
1010
name: pyroscope-main
1111
runs-on: ubuntu-latest
1212
if: "startsWith(github.ref, 'refs/tags/lib-')"
13-
continue-on-error: true
13+
continue-on-error: false
14+
permissions:
15+
contents: write
1416
steps:
1517
- uses: "marvinpinto/action-automatic-releases@919008cf3f741b179569b7a6fb4d8860689ab7f0" # v1.2.1 TODO(korniltsev): get rid of this, this one is unmaintained
1618
with:
@@ -25,6 +27,8 @@ jobs:
2527
if: "startsWith(github.ref, 'refs/tags/cli-')"
2628
outputs:
2729
upload_url: ${{ steps.auto-release.outputs.upload_url }}
30+
permissions:
31+
contents: write
2832
steps:
2933
- id: auto-release
3034
uses: "marvinpinto/action-automatic-releases@919008cf3f741b179569b7a6fb4d8860689ab7f0" # v1.2.1 TODO(korniltsev): get rid of this, this one is unmaintained
@@ -63,7 +67,9 @@ jobs:
6367
name: pyroscope-pprofrs
6468
runs-on: ubuntu-latest
6569
if: "startsWith(github.ref, 'refs/tags/pprofrs-')"
66-
continue-on-error: true
70+
continue-on-error: false
71+
permissions:
72+
contents: write
6773
steps:
6874
- uses: "marvinpinto/action-automatic-releases@919008cf3f741b179569b7a6fb4d8860689ab7f0" # v1.2.1 TODO(korniltsev): get rid of this, this one is unmaintained
6975
with:
@@ -76,7 +82,9 @@ jobs:
7682
name: pyroscope-rbspy
7783
runs-on: ubuntu-latest
7884
if: "startsWith(github.ref, 'refs/tags/rbspy-')"
79-
continue-on-error: true
85+
continue-on-error: false
86+
permissions:
87+
contents: write
8088
steps:
8189
- uses: "marvinpinto/action-automatic-releases@919008cf3f741b179569b7a6fb4d8860689ab7f0" # v1.2.1 TODO(korniltsev): get rid of this, this one is unmaintained
8290
with:
@@ -89,7 +97,9 @@ jobs:
8997
name: pyroscope-pyspy
9098
runs-on: ubuntu-latest
9199
if: "startsWith(github.ref, 'refs/tags/pyspy-')"
92-
continue-on-error: true
100+
continue-on-error: false
101+
permissions:
102+
contents: write
93103
steps:
94104
- uses: "marvinpinto/action-automatic-releases@919008cf3f741b179569b7a6fb4d8860689ab7f0" # v1.2.1 TODO(korniltsev): get rid of this, this one is unmaintained
95105
with:
@@ -220,7 +230,9 @@ jobs:
220230
name: Python Package
221231
runs-on: ubuntu-latest
222232
if: "startsWith(github.ref, 'refs/tags/python-')"
223-
continue-on-error: true
233+
continue-on-error: false
234+
permissions:
235+
contents: write
224236
outputs:
225237
upload_url: ${{ steps.auto-release.outputs.upload_url }}
226238
steps:
@@ -358,7 +370,9 @@ jobs:
358370
name: Ruby Gem
359371
runs-on: ubuntu-latest
360372
if: "startsWith(github.ref, 'refs/tags/ruby-')"
361-
continue-on-error: true
373+
continue-on-error: false
374+
permissions:
375+
contents: write
362376
outputs:
363377
upload_url: ${{ steps.auto-release.outputs.upload_url }}
364378
steps:

0 commit comments

Comments
 (0)