Merge pull request #56 from pyroscope-io/0.5.4

0.5.4

Author: petethepig

CHANGELOG.md

@@ -1,5 +1,14 @@
+# v0.5.4
+## New Features
+- Add report transfromation function which allows changing the report before
+  sending it to the Pyroscope Server.
+- Add Gzip support.
+
+## Bug Fixes
+- Use URL Builder. ([786c89b](https://github.com/pyroscope-io/pyroscope-rs/commit/786c89bb99839c45778410012a6da60267d395df))
+
 # v0.5.3
-## New features
+## New Features
 - Add BackendConfig to make reporting of pid, thread_id and thread_name
   optional. 
 - Backends can add a suffix to the "application_name"

Cargo.toml

@@ -56,6 +56,7 @@ log = "0.4"
 names = "0.13.0"
 reqwest = { version = "0.11", features = ["blocking", "rustls-tls-native-roots"]}
 url = "2.2.2"
+libflate = "1.2.0"
 libc = "^0.2.124"
 
 [dev-dependencies]

examples/internal/pyspy-connect.rs

@@ -20,8 +20,8 @@ fn main() -> Result<()> {
         .sample_rate(100)
         .lock_process(true)
         .time_limit(None)
-        .with_subprocesses(true)
-        .include_idle(false)
+        .detect_subprocesses(true)
+        .oncpu(false)
         .native(false);
 
     let agent = PyroscopeAgent::builder("http://localhost:4040", "pyspy.basic")

examples/internal/rbspy-connect.rs

@@ -19,7 +19,7 @@ fn main() -> Result<()> {
     let config = RbspyConfig::new(pid)
         .sample_rate(100)
         .lock_process(true)
-        .with_subprocesses(true);
+        .detect_subprocesses(true);
 
     let agent = PyroscopeAgent::builder("http://localhost:4040", "rbspy.basic")
         .tags([("Host", "Ruby")].to_vec())

pyroscope_ffi/ffikit/src/lib.rs

@@ -23,9 +23,13 @@ static ONCE: Once = Once::new();
 
 lazy_static! {
     /// Root Sender
+    /// This is the sender to the main loop. It is lazily initialized inside a Mutex.
     static ref SENDER: Mutex<Option<Sender<Signal>>> = Mutex::new(None);
 }
 
+/// Signal enum.
+/// This enum is used to send signals to the main loop. It is used to add/remove global or thread
+/// tags and to exit the main loop.
 #[derive(Debug, Encode, Decode, PartialEq, Clone)]
 pub enum Signal {
     Kill,
@@ -52,7 +56,7 @@ pub fn initialize_ffi() -> Result<Receiver<Signal>> {
 
         // Listen for signals on the main parent process.
         let fn_sender = merge_sender.clone();
-        let channel_listener: JoinHandle<Result<()>> = std::thread::spawn(move || {
+        let _channel_listener: JoinHandle<Result<()>> = std::thread::spawn(move || {
             log::trace!("Spawned FFI listener thread.");
 
             while let Ok(signal) = receiver.recv() {
@@ -81,7 +85,7 @@ pub fn initialize_ffi() -> Result<Receiver<Signal>> {
 
         // Listen for signals on local socket
         let socket_sender = merge_sender.clone();
-        let socket_listener: JoinHandle<Result<()>> = std::thread::spawn(move || {
+        let _socket_listener: JoinHandle<Result<()>> = std::thread::spawn(move || {
             let socket_address = format!("/tmp/PYROSCOPE-{}", get_parent_pid());
 
             log::trace!(
@@ -158,7 +162,16 @@ pub fn send(signal: Signal) -> Result<()> {
         conn.flush()?;
     } else {
         // Send signal through parent process.
-        SENDER.lock()?.as_ref().unwrap().send(signal)?;
+        if let Some(sender) = &*SENDER.lock()? {
+            log::trace!(
+                target: LOG_TAG,
+                "Sending signal {:?} through FFI channel",
+                signal
+            );
+            sender.send(signal)?;
+        } else {
+            log::error!(target: LOG_TAG, "FFI channel not initialized");
+        }
     }
 
     Ok(())

pyroscope_ffi/python/setup.cfg

@@ -1,6 +1,6 @@
 [metadata]
 name = pyroscope-io
-version= 0.7.2
+version= 0.7.3
 description = Pyroscope Python integration
 long_description = file: README.md
 long_description_content_type = text/markdown

pyroscope_ffi/ruby/ext/rbspy/src/lib.rs

@@ -1,12 +1,15 @@
-use ffikit::Signal;
-use pyroscope::backend::{Report, StackFrame, Tag};
-use pyroscope::PyroscopeAgent;
-use pyroscope_rbspy::{rbspy_backend, RbspyConfig};
 use std::collections::hash_map::DefaultHasher;
 use std::env;
 use std::ffi::CStr;
 use std::hash::Hasher;
 use std::os::raw::c_char;
+use std::str::FromStr;
+
+use ffikit::Signal;
+use pyroscope_rbspy::{rbspy_backend, RbspyConfig};
+
+use pyroscope::{pyroscope::Compression, PyroscopeAgent};
+use pyroscope::backend::{Report, StackFrame, Tag};
 
 pub fn transform_report(report: Report) -> Report {
     let cwd = env::current_dir().unwrap();
@@ -104,7 +107,7 @@ pub extern "C" fn initialize_logging(logging_level: u32) -> bool {
 pub extern "C" fn initialize_agent(
     application_name: *const c_char, server_address: *const c_char, auth_token: *const c_char,
     sample_rate: u32, detect_subprocesses: bool, oncpu: bool, report_pid: bool,
-    report_thread_id: bool, tags: *const c_char,
+    report_thread_id: bool, tags: *const c_char, compression: *const c_char
 ) -> bool {
     // Initialize FFIKit
     let recv = ffikit::initialize_ffi().unwrap();
@@ -129,6 +132,13 @@ pub extern "C" fn initialize_agent(
         .unwrap()
         .to_string();
 
+    let compression_string = unsafe { CStr::from_ptr(compression) }
+        .to_str()
+        .unwrap()
+        .to_string();
+
+    let compression = Compression::from_str(&compression_string);
+
     let pid = std::process::id();
 
     let rbspy_config = RbspyConfig::new(pid.try_into().unwrap())
@@ -152,6 +162,10 @@ pub extern "C" fn initialize_agent(
         agent_builder = agent_builder.auth_token(auth_token);
     }
 
+    if let Ok(compression) = compression {
+        agent_builder = agent_builder.compression(compression);
+    }
+
     let agent = agent_builder.build().unwrap();
 
     let agent_running = agent.start().unwrap();

pyroscope_ffi/ruby/lib/pyroscope.rb

@@ -8,7 +8,7 @@ module Rust
     extend FFI::Library
     ffi_lib File.expand_path(File.dirname(__FILE__)) + "/rbspy/rbspy.#{RbConfig::CONFIG["DLEXT"]}"
     attach_function :initialize_logging, [:int], :bool
-    attach_function :initialize_agent, [:string, :string, :string, :int, :bool, :bool, :bool, :bool, :string], :bool
+    attach_function :initialize_agent, [:string, :string, :string, :int, :bool, :bool, :bool, :bool, :string, :string], :bool
     attach_function :add_thread_tag, [:uint64, :string, :string], :bool
     attach_function :remove_thread_tag, [:uint64, :string, :string], :bool
     attach_function :add_global_tag, [:string, :string], :bool
@@ -22,8 +22,10 @@ module Utils
     attach_function :thread_id, [], :uint64
   end
 
-  Config = Struct.new(:application_name, :app_name, :server_address, :auth_token, :log_level, :sample_rate, :detect_subprocesses, :oncpu, :report_pid, :report_thread_id, :tags) do
+  Config = Struct.new(:application_name, :app_name, :server_address, :auth_token, :log_level, :sample_rate, :detect_subprocesses, :oncpu, :report_pid, :report_thread_id, :tags, :compression) do
     def initialize(*)
+      super
+      # defaults:
       self.application_name = ''
       self.server_address = 'http://localhost:4040'
       self.auth_token = ''
@@ -34,7 +36,7 @@ def initialize(*)
       self.report_thread_id = false
       self.log_level = 'error'
       self.tags = {}
-      super
+      self.compression = 'gzip'
     end
   end
 
@@ -63,10 +65,11 @@ def configure
 
       # Initialize Logging
       Rust.initialize_logging(@log_level)
-      
+
 
       # initialize Pyroscope Agent
       Rust.initialize_agent(
+        # these are defaults in case user-provided values are nil:
         @config.app_name || @config.application_name || "",
         @config.server_address || "",
         @config.auth_token || "",
@@ -75,7 +78,8 @@ def configure
         @config.oncpu || false,
         @config.report_pid || false,
         @config.report_thread_id || false,
-        tags_to_string(@config.tags || {})
+        tags_to_string(@config.tags || {}),
+        @config.compression || ""
       )
     end
 

pyroscope_ffi/ruby/lib/pyroscope/version.rb

@@ -1,3 +1,3 @@
 module Pyroscope
-  VERSION = '0.3.2'.freeze
+  VERSION = '0.4.1'.freeze
 end

src/backend/backend.rs

@@ -12,25 +12,14 @@ use std::{
 use super::Report;
 
 /// Backend Config
-#[derive(Debug, Copy, Clone)]
+#[derive(Debug, Copy, Clone, Default)]
 pub struct BackendConfig {
     pub report_thread_id: bool,
     pub report_thread_name: bool,
     pub report_pid: bool,
     pub report_oncpu: bool,
 }
 
-impl Default for BackendConfig {
-    fn default() -> Self {
-        Self {
-            report_thread_id: false,
-            report_thread_name: false,
-            report_pid: false,
-            report_oncpu: false,
-        }
-    }
-}
-
 /// Backend Trait
 pub trait Backend: Send + Debug {
     /// Backend Spy Name