refactor(tags): change tags parameter type to Vec

Author: omarabid

examples/async.rs

@@ -36,7 +36,7 @@ fn hash_rounds2(n: u64) -> u64 {
 async fn main() -> Result<()> {
     let mut agent = PyroscopeAgent::builder("http://localhost:4040", "example.async")
         .backend(Pprof::new(PprofConfig::new(100)))
-        .tags(&[("TagA", "ValueA"), ("TagB", "ValueB")])
+        .tags([("TagA", "ValueA"), ("TagB", "ValueB")].to_vec())
         .build()?;
 
     // Start Agent

examples/backend.rs

@@ -21,7 +21,7 @@ fn hash_rounds(n: u64) -> u64 {
 fn main() -> Result<()> {
     let mut agent = PyroscopeAgent::builder("http://localhost:4040", "example.backend")
         .backend(Pprof::new(PprofConfig::new(113)))
-        .tags(&[("TagA", "ValueA"), ("TagB", "ValueB")])
+        .tags([("TagA", "ValueA"), ("TagB", "ValueB")].to_vec())
         .build()?;
 
     agent.start()?;

examples/basic.rs

@@ -21,7 +21,7 @@ fn hash_rounds(n: u64) -> u64 {
 fn main() -> Result<()> {
     let mut agent = PyroscopeAgent::builder("http://localhost:4040", "example.basic")
         .backend(Pprof::new(PprofConfig::new(100)))
-        .tags(&[("TagA", "ValueA"), ("TagB", "ValueB")])
+        .tags([("TagA", "ValueA"), ("TagB", "ValueB")].to_vec())
         .build()?;
 
     // Show start time

examples/tags.rs

@@ -21,7 +21,7 @@ fn hash_rounds(n: u64) -> u64 {
 fn main() -> Result<()> {
     let mut agent = PyroscopeAgent::builder("http://localhost:4040", "example.tags")
         .backend(Pprof::new(PprofConfig::new(100)))
-        .tags(&[("Hostname", "pyroscope")])
+        .tags([("Hostname", "pyroscope")].to_vec())
         .build()?;
 
     // Start Agent

src/pyroscope.rs

@@ -79,7 +79,7 @@ impl PyroscopeConfig {
     /// let config = PyroscopeConfig::new("http://localhost:8080", "my-app")
     ///    .tags(vec![("env", "dev")])?;
     /// ```
-    pub fn tags(self, tags: &[(&str, &str)]) -> Self {
+    pub fn tags(self, tags: Vec<(&str, &str)>) -> Self {
         // Convert &[(&str, &str)] to HashMap(String, String)
         let tags_hashmap: HashMap<String, String> = tags
             .to_owned()
@@ -156,7 +156,7 @@ impl PyroscopeAgentBuilder {
     /// .build()
     /// ?;
     /// ```
-    pub fn tags(self, tags: &[(&str, &str)]) -> Self {
+    pub fn tags(self, tags: Vec<(&str, &str)>) -> Self {
         Self {
             config: self.config.tags(tags),
             ..self

tests/agent.rs

@@ -23,15 +23,16 @@ fn test_config_tags_empty() {
 
 #[test]
 fn test_config_tags() {
-    let config = PyroscopeConfig::new("http://localhost:8080", "myapp").tags(&[("tag", "value")]);
+    let config =
+        PyroscopeConfig::new("http://localhost:8080", "myapp").tags([("tag", "value")].to_vec());
     assert_eq!(config.tags.len(), 1);
     assert_eq!(config.tags.get("tag"), Some(&"value".to_owned()));
 }
 
 #[test]
 fn test_config_tags_multiple() {
     let config = PyroscopeConfig::new("http://localhost:8080", "myapp")
-        .tags(&[("tag1", "value1"), ("tag2", "value2")]);
+        .tags([("tag1", "value1"), ("tag2", "value2")].to_vec());
     assert_eq!(config.tags.len(), 2);
     assert_eq!(config.tags.get("tag1"), Some(&"value1".to_owned()));
     assert_eq!(config.tags.get("tag2"), Some(&"value2".to_owned()));