Skip to content

Commit a72a25c

Browse files
committed
maybe fix release workflows asset uploading
1 parent 2cc7ab2 commit a72a25c

File tree

2 files changed

+1
-25
lines changed

2 files changed

+1
-25
lines changed

.github/workflows/publish.yml

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -21,7 +21,6 @@ jobs:
2121
with:
2222
toolchain: 1.85.0
2323
- name: publish pyroscope crate
24-
continue-on-error: false
2524
run: |
2625
cargo login ${{ secrets.CARGO_TOKEN }}
2726
cargo publish
@@ -37,7 +36,6 @@ jobs:
3736
with:
3837
toolchain: 1.85.0
3938
- name: publish pprofrs crate
40-
continue-on-error: false
4139
run: |
4240
set -ex
4341
cargo login ${{ secrets.CARGO_TOKEN }}
@@ -54,7 +52,6 @@ jobs:
5452
with:
5553
toolchain: 1.85.0
5654
- name: publish rbspy crate
57-
continue-on-error: false
5855
run: |
5956
cargo login ${{ secrets.CARGO_TOKEN }}
6057
cargo publish --manifest-path pyroscope_backends/pyroscope_rbspy/Cargo.toml
@@ -70,7 +67,6 @@ jobs:
7067
with:
7168
toolchain: 1.85.0
7269
- name: publish pyspy crate
73-
continue-on-error: false
7470
run: |
7571
cargo login ${{ secrets.CARGO_TOKEN }}
7672
cargo publish --manifest-path pyroscope_backends/pyroscope_pyspy/Cargo.toml

.github/workflows/release.yml

Lines changed: 1 addition & 21 deletions
Original file line numberDiff line numberDiff line change
@@ -3,16 +3,13 @@ name: Pre-Release
33
on: [ push ]
44

55
permissions:
6-
contents: read
6+
contents: write
77

88
jobs:
99
lib-release:
1010
name: pyroscope-main
1111
runs-on: ubuntu-latest
1212
if: "startsWith(github.ref, 'refs/tags/lib-')"
13-
continue-on-error: false
14-
permissions:
15-
contents: write
1613
steps:
1714
- uses: "marvinpinto/action-automatic-releases@919008cf3f741b179569b7a6fb4d8860689ab7f0" # v1.2.1 TODO(korniltsev): get rid of this, this one is unmaintained
1815
with:
@@ -27,8 +24,6 @@ jobs:
2724
if: "startsWith(github.ref, 'refs/tags/cli-')"
2825
outputs:
2926
upload_url: ${{ steps.auto-release.outputs.upload_url }}
30-
permissions:
31-
contents: write
3227
steps:
3328
- id: auto-release
3429
uses: "marvinpinto/action-automatic-releases@919008cf3f741b179569b7a6fb4d8860689ab7f0" # v1.2.1 TODO(korniltsev): get rid of this, this one is unmaintained
@@ -67,9 +62,6 @@ jobs:
6762
name: pyroscope-pprofrs
6863
runs-on: ubuntu-latest
6964
if: "startsWith(github.ref, 'refs/tags/pprofrs-')"
70-
continue-on-error: false
71-
permissions:
72-
contents: write
7365
steps:
7466
- uses: "marvinpinto/action-automatic-releases@919008cf3f741b179569b7a6fb4d8860689ab7f0" # v1.2.1 TODO(korniltsev): get rid of this, this one is unmaintained
7567
with:
@@ -82,9 +74,6 @@ jobs:
8274
name: pyroscope-rbspy
8375
runs-on: ubuntu-latest
8476
if: "startsWith(github.ref, 'refs/tags/rbspy-')"
85-
continue-on-error: false
86-
permissions:
87-
contents: write
8877
steps:
8978
- uses: "marvinpinto/action-automatic-releases@919008cf3f741b179569b7a6fb4d8860689ab7f0" # v1.2.1 TODO(korniltsev): get rid of this, this one is unmaintained
9079
with:
@@ -97,9 +86,6 @@ jobs:
9786
name: pyroscope-pyspy
9887
runs-on: ubuntu-latest
9988
if: "startsWith(github.ref, 'refs/tags/pyspy-')"
100-
continue-on-error: false
101-
permissions:
102-
contents: write
10389
steps:
10490
- uses: "marvinpinto/action-automatic-releases@919008cf3f741b179569b7a6fb4d8860689ab7f0" # v1.2.1 TODO(korniltsev): get rid of this, this one is unmaintained
10591
with:
@@ -230,9 +216,6 @@ jobs:
230216
name: Python Package
231217
runs-on: ubuntu-latest
232218
if: "startsWith(github.ref, 'refs/tags/python-')"
233-
continue-on-error: false
234-
permissions:
235-
contents: write
236219
outputs:
237220
upload_url: ${{ steps.auto-release.outputs.upload_url }}
238221
steps:
@@ -370,9 +353,6 @@ jobs:
370353
name: Ruby Gem
371354
runs-on: ubuntu-latest
372355
if: "startsWith(github.ref, 'refs/tags/ruby-')"
373-
continue-on-error: false
374-
permissions:
375-
contents: write
376356
outputs:
377357
upload_url: ${{ steps.auto-release.outputs.upload_url }}
378358
steps:

0 commit comments

Comments
 (0)