Merge pull request #26 from pyroscope-io/0.5.1

0.5.1

Author: omarabid

Cargo.toml

@@ -5,7 +5,7 @@ Pyroscope Profiler Agent for continuous profiling of Rust, Python and Ruby appli
 """
 keywords = ["pyroscope", "profiler", "profiling", "pprof"]
 authors = ["Abid Omar <[email protected]>"]
-version = "0.5.0"
+version = "0.5.1"
 edition = "2021"
 license = "Apache-2.0"
 homepage = "https://pyroscope.io/docs/rust"

README.md

@@ -36,19 +36,19 @@ pyroscope = "0.5.0"
 pyroscope-pprofrs = "0.2"
 ```
 
-Configure and create the backend (pprof-rs)
+Include Pyroscope and pprof-rs dependencies:
 
 ```rust
-let pprof_config = PprofConfig::new().sample_rate(100);
-let pprof_backend = Pprof::new(pprof_config);
+use pyroscope::PyroscopeAgent;
+use pyroscope_pprofrs::{pprof_backend, PprofConfig};
 ```
 
 Configure the Pyroscope agent:
 
 ```rust
  let agent =
      PyroscopeAgent::builder("http://localhost:4040", "myapp-profile")
-     .backend(pprof_backend)
+     .backend(pprof_backend(PprofConfig::new().sample_rate(100)))
      .build()?;
 ```
 

src/pyroscope.rs

@@ -266,6 +266,12 @@ impl<S: PyroscopeAgentState> PyroscopeAgent<S> {
     pub fn shutdown(mut self) {
         log::debug!(target: LOG_TAG, "PyroscopeAgent::drop()");
 
+        // Shutdown Backend
+        match self.backend.shutdown() {
+            Ok(_) => log::debug!(target: LOG_TAG, "Backend shutdown"),
+            Err(e) => log::error!(target: LOG_TAG, "Backend shutdown error: {}", e),
+        }
+
         // Drop Timer listeners
         match self.timer.drop_listeners() {
             Ok(_) => log::trace!(target: LOG_TAG, "Dropped timer listeners"),