refactor(clippy): fix clippy warnings

Author: omarabid

pyroscope_backends/pyroscope_pprofrs/src/lib.rs

@@ -23,10 +23,7 @@ impl PprofConfig {
     }
 
     pub fn sample_rate(self, sample_rate: u32) -> Self {
-        PprofConfig {
-            sample_rate,
-            ..self
-        }
+        PprofConfig { sample_rate }
     }
 }
 
@@ -213,17 +210,17 @@ impl From<pprof::Symbol> for StackFrameWrapper {
                 symbol
                     .filename
                     .clone()
-                    .unwrap_or(std::path::PathBuf::new())
+                    .unwrap_or_else(std::path::PathBuf::new)
                     .file_name()
-                    .unwrap_or(OsStr::new(""))
+                    .unwrap_or_else(|| OsStr::new(""))
                     .to_str()
                     .unwrap_or("")
                     .to_string(),
             ),
             Some(
                 symbol
                     .filename
-                    .unwrap_or(std::path::PathBuf::new())
+                    .unwrap_or_else(std::path::PathBuf::new)
                     .to_str()
                     .unwrap_or("")
                     .to_string(),

pyroscope_backends/pyroscope_rbspy/src/lib.rs

@@ -104,6 +104,10 @@ impl Rbspy {
     }
 }
 
+// Type aliases
+type ErrorSender = Sender<std::result::Result<(), anyhow::Error>>;
+type ErrorReceiver = Receiver<std::result::Result<(), anyhow::Error>>;
+
 impl Backend for Rbspy {
     fn get_state(&self) -> State {
         self.state
@@ -150,10 +154,7 @@ impl Backend for Rbspy {
         }
 
         // Channel for Errors generated by the RubySpy Sampler
-        let (error_sender, error_receiver): (
-            Sender<std::result::Result<(), anyhow::Error>>,
-            Receiver<std::result::Result<(), anyhow::Error>>,
-        ) = channel();
+        let (error_sender, error_receiver): (ErrorSender, ErrorReceiver) = channel();
 
         // This is provides enough space for 100 threads.
         // It might be a better idea to figure out how many threads are running and determine the