feat: Set querier.max-flamegraph-nodes-max default to 1,048,576 (#4370)

Author: bryanhuhta

cmd/pyroscope/help-all.txt.tmpl

@@ -576,7 +576,7 @@ Usage of ./pyroscope:
   -querier.max-flamegraph-nodes-default int
     	Maximum number of flame graph nodes by default. 0 to disable. (default 8192)
   -querier.max-flamegraph-nodes-max int
-    	Maximum number of flame graph nodes allowed. 0 to disable.
+    	Maximum number of flame graph nodes allowed. 0 to disable. (default 1048576)
   -querier.max-query-length duration
     	The limit to length of queries. 0 to disable. (default 1d)
   -querier.max-query-lookback duration

cmd/pyroscope/help.txt.tmpl

@@ -160,7 +160,7 @@ Usage of ./pyroscope:
   -querier.max-flamegraph-nodes-default int
     	Maximum number of flame graph nodes by default. 0 to disable. (default 8192)
   -querier.max-flamegraph-nodes-max int
-    	Maximum number of flame graph nodes allowed. 0 to disable.
+    	Maximum number of flame graph nodes allowed. 0 to disable. (default 1048576)
   -querier.max-query-length duration
     	The limit to length of queries. 0 to disable. (default 1d)
   -querier.max-query-lookback duration

docs/sources/configure-server/reference-configuration-parameters/index.md

@@ -2272,7 +2272,7 @@ distributor_usage_groups:
 
 # Maximum number of flame graph nodes allowed. 0 to disable.
 # CLI flag: -querier.max-flamegraph-nodes-max
-[max_flamegraph_nodes_max: <int> | default = 0]
+[max_flamegraph_nodes_max: <int> | default = 1048576]
 
 # The tenant's shard size, used when store-gateway sharding is enabled. Value of
 # 0 disables shuffle sharding for the tenant, that is all tenant blocks are

pkg/validation/limits.go

@@ -180,7 +180,7 @@ func (l *Limits) RegisterFlags(f *flag.FlagSet) {
 	f.IntVar(&l.MaxProfileSymbolValueLength, "validation.max-profile-symbol-value-length", 65535, "Maximum length of a profile symbol value (labels, function names and filenames, etc...). Profiles are not rejected instead symbol values are truncated. 0 to disable.")
 
 	f.IntVar(&l.MaxFlameGraphNodesDefault, "querier.max-flamegraph-nodes-default", 8<<10, "Maximum number of flame graph nodes by default. 0 to disable.")
-	f.IntVar(&l.MaxFlameGraphNodesMax, "querier.max-flamegraph-nodes-max", 0, "Maximum number of flame graph nodes allowed. 0 to disable.")
+	f.IntVar(&l.MaxFlameGraphNodesMax, "querier.max-flamegraph-nodes-max", 1<<20, "Maximum number of flame graph nodes allowed. 0 to disable.")
 
 	f.Var(&l.DistributorAggregationWindow, "distributor.aggregation-window", "Duration of the distributor aggregation window. Requires aggregation period to be specified. 0 to disable.")
 	f.Var(&l.DistributorAggregationPeriod, "distributor.aggregation-period", "Duration of the distributor aggregation period. Requires aggregation window to be specified. 0 to disable.")