distributor: add new metrics #4367
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aleks-p
approved these changes
Aug 11, 2025
| receivedDecompressedBytesTotal: prometheus.NewHistogramVec( | ||
| prometheus.HistogramOpts{ | ||
| Namespace: "pyroscope", | ||
| Name: "distributor_received_decompressed_bytes_total", |
There was a problem hiding this comment.
I expect this to be confused with the existing metric because they have an overlapping name, but I can't think of a better name. Perhaps once we validate that this metric works the way we want, we can remove or rename the existing one (potentially breaking dashboards in the process).
korniltsev
added a commit
that referenced
this pull request
Aug 12, 2025
korniltsev
added a commit
that referenced
this pull request
Aug 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Suggesting new metrics for these issues
https://github.com/grafana/pyroscope-squad/issues/557
https://github.com/grafana/pyroscope-squad/issues/346
distributor_received_decompressed_bytes_total- incremented for each received profile as soon we try processing the profile, before any ratelimit/sampling checksdistributor_processed_decompressed_bytes- incremented after ratelimit/sampling checks at the exit of the processing routine withdefer(note : potentially after normalization if the profile is valid)TODO: add tests