Skip to content

Commit 0d00f5b

Browse files
committed
update to use uint32 everywhere
1 parent a078f64 commit 0d00f5b

File tree

2 files changed

+4
-4
lines changed

2 files changed

+4
-4
lines changed

modules/frontend/metrics_query_range_sharder.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -115,7 +115,7 @@ func (s queryRangeSharder) RoundTrip(pipelineRequest pipeline.Request) (pipeline
115115
}
116116

117117
traceql.AlignRequest(req)
118-
118+
119119
// Instant queries must not compute exemplars
120120
if s.instantMode {
121121
req.Exemplars = 0

pkg/traceql/engine_metrics_compare.go

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -40,7 +40,7 @@ type MetricsCompare struct {
4040
baselineExemplars []Exemplar
4141
selectionExemplars []Exemplar
4242
seriesAgg SeriesAggregator
43-
maxExemplars int
43+
maxExemplars uint32
4444

4545
// Runtime fields to avoid allocating closures
4646
// and escaping to the heap when we call span.AllAttributesFunc.
@@ -83,7 +83,7 @@ func (m *MetricsCompare) init(q *tempopb.QueryRangeRequest, mode AggregateMode)
8383
m.selections = make(map[Attribute]map[StaticMapKey]*staticWithCounts)
8484
m.baselineTotals = make(map[Attribute][]float64)
8585
m.selectionTotals = make(map[Attribute][]float64)
86-
m.maxExemplars = int(q.Exemplars)
86+
m.maxExemplars = q.Exemplars
8787

8888
case AggregateModeSum:
8989
m.seriesAgg = NewSimpleCombiner(q, sumAggregation)
@@ -187,7 +187,7 @@ func (m *MetricsCompare) observeExemplar(span Span) {
187187
isSelection := m.isSelection(span, st)
188188

189189
// Exemplars
190-
if len(m.baselineExemplars) >= m.maxExemplars || len(m.selectionExemplars) >= m.maxExemplars {
190+
if uint32(len(m.baselineExemplars)) >= m.maxExemplars || uint32(len(m.selectionExemplars)) >= m.maxExemplars {
191191
return
192192
}
193193

0 commit comments

Comments
 (0)