Skip to content

Commit 12c5d96

Browse files
Cloud Plugins tests: Delete existing as pre-check (#657)
We've been getting some `Plugin is already installed on this instance` in the tests. This should fix it forever
1 parent d9131a0 commit 12c5d96

File tree

1 file changed

+16
-0
lines changed

1 file changed

+16
-0
lines changed

grafana/resource_cloud_plugin_test.go

Lines changed: 16 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -16,6 +16,8 @@ func TestAccResourceCloudPluginInstallation(t *testing.T) {
1616
pluginVersion := "1.7.0"
1717

1818
resource.Test(t, resource.TestCase{
19+
PreCheck: func() { testAccCloudPluginDeleteExisting(t, slug, pluginSlug) },
20+
1921
ProviderFactories: testAccProviderFactories,
2022
Steps: []resource.TestStep{
2123
{
@@ -71,6 +73,20 @@ func testAccCloudPluginInstallationDestroy(stackSlug string, pluginSlug string)
7173
}
7274
}
7375

76+
func testAccCloudPluginDeleteExisting(t *testing.T, instanceSlug, pluginSlug string) {
77+
client := testAccProvider.Meta().(*client).gcloudapi
78+
installed, err := client.IsCloudPluginInstalled(instanceSlug, pluginSlug)
79+
if err != nil {
80+
t.Fatalf("error checking if plugin is installed: %s", err)
81+
}
82+
if installed {
83+
err = client.UninstallCloudPlugin(instanceSlug, pluginSlug)
84+
if err != nil {
85+
t.Fatalf("error uninstalling plugin: %s", err)
86+
}
87+
}
88+
}
89+
7490
func testAccGrafanaCloudPluginInstallation(stackSlug, name, version string) string {
7591
return fmt.Sprintf(`
7692
resource "grafana_cloud_plugin_installation" "test-installation" {

0 commit comments

Comments
 (0)