Merge pull request #322 from grafana/bug-234

Make secure_settings always pass values as string

Author: inkel

grafana/resource_alert_notification.go

@@ -224,14 +224,10 @@ func makeAlertNotification(_ context.Context, d *schema.ResourceData) (*gapi.Ale
 	secureSettings := map[string]interface{}{}
 	for k, v := range d.Get("secure_settings").(map[string]interface{}) {
 		strVal, ok := v.(string)
-		switch {
-		case ok && strVal == "true":
-			secureSettings[k] = true
-		case ok && strVal == "false":
-			secureSettings[k] = false
-		default:
-			secureSettings[k] = v
+		if !ok {
+			return nil, errors.New("secure_settings must be a map of string")
 		}
+		secureSettings[k] = strVal
 	}
 
 	sendReminder := d.Get("send_reminder").(bool)

grafana/resource_alert_notification_test.go

@@ -186,6 +186,9 @@ resource "grafana_alert_notification" "test" {
 			"uploadImage" = "false"
 			"autoResolve" = "true"
 		}
+	secure_settings = {
+		 "foo" = "true"
+	}
 }
 `