Split resources and provider into different packages (#810)

Follow-up to #807
Following the `terraform-provider-aws` repository structure, the main provider instance is in its own package, and resources are separated from it
For now, all resource are in a `grafana` package but I will split this off into multiple resource packages

Author: julienduchesne

provider/common/adapters.go internal/common/adapters.goprovider/common/adapters.go renamed to internal/common/adapters.go

@@ -0,0 +1,10 @@
+package common
+
+import "regexp"
+
+var (
+	IDRegexp     = regexp.MustCompile(`^\d+$`)
+	UIDRegexp    = regexp.MustCompile(`^[a-zA-Z0-9-_]+$`)
+	EmailRegexp  = regexp.MustCompile(`.+\@.+\..+`)
+	SHA256Regexp = regexp.MustCompile(`^[A-Fa-f0-9]{64}$`)
+)

provider/common/client.go internal/common/client.goprovider/common/client.go renamed to internal/common/client.go

@@ -1,4 +1,4 @@
-package provider
+package grafana
 
 import (
 	"context"

provider/common/json.go internal/common/json.goprovider/common/json.go renamed to internal/common/json.go

@@ -1,4 +1,4 @@
-package provider
+package grafana_test
 
 import (
 	"fmt"
@@ -7,7 +7,7 @@ import (
 	"strings"
 	"testing"
 
-	"github.com/grafana/terraform-provider-grafana/provider/testutils"
+	"github.com/grafana/terraform-provider-grafana/internal/testutils"
 	"github.com/hashicorp/terraform-plugin-sdk/v2/helper/resource"
 	"github.com/hashicorp/terraform-plugin-sdk/v2/terraform"
 )

internal/common/regex.go

@@ -1,11 +1,11 @@
-package provider
+package grafana
 
 import (
 	"context"
 	"strconv"
 	"time"
 
-	"github.com/grafana/terraform-provider-grafana/provider/common"
+	"github.com/grafana/terraform-provider-grafana/internal/common"
 	"github.com/hashicorp/terraform-plugin-sdk/v2/diag"
 	"github.com/hashicorp/terraform-plugin-sdk/v2/helper/schema"
 )

provider/common/schema.go internal/common/schema.goprovider/common/schema.go renamed to internal/common/schema.go

@@ -1,11 +1,12 @@
-package provider
+package grafana_test
 
 import (
 	"fmt"
 	"os"
 	"testing"
 
-	"github.com/grafana/terraform-provider-grafana/provider/testutils"
+	"github.com/grafana/terraform-provider-grafana/internal/common"
+	"github.com/grafana/terraform-provider-grafana/internal/testutils"
 	"github.com/hashicorp/terraform-plugin-sdk/v2/helper/resource"
 )
 
@@ -24,7 +25,7 @@ func TestAccDatasourceCloudOrganization_Basic(t *testing.T) {
 			{
 				Config: config,
 				Check: resource.ComposeTestCheckFunc(
-					resource.TestMatchResourceAttr("data.grafana_cloud_organization.test", "id", idRegexp),
+					resource.TestMatchResourceAttr("data.grafana_cloud_organization.test", "id", common.IDRegexp),
 					resource.TestCheckResourceAttr("data.grafana_cloud_organization.test", "slug", os.Getenv("GRAFANA_CLOUD_ORG")),
 					resource.TestCheckResourceAttrSet("data.grafana_cloud_organization.test", "name"),
 					resource.TestCheckResourceAttrSet("data.grafana_cloud_organization.test", "created_at"),

provider/data_source_cloud_ips.go internal/grafana/data_source_cloud_ips.goprovider/data_source_cloud_ips.go renamed to internal/grafana/data_source_cloud_ips.go

@@ -1,9 +1,9 @@
-package provider
+package grafana
 
 import (
 	"context"
 
-	"github.com/grafana/terraform-provider-grafana/provider/common"
+	"github.com/grafana/terraform-provider-grafana/internal/common"
 	"github.com/hashicorp/terraform-plugin-sdk/v2/diag"
 	"github.com/hashicorp/terraform-plugin-sdk/v2/helper/schema"
 )