applatform: remove dynamic types from alertrule resource (#2463)

This dynamic type was preventing generation of crossplane provider tooling as dynamic types are not supported. Follow up to #2426

Co-authored-by: William Wernert <[email protected]>

Author: moustafab

docs/resources/apps_rules_alertrule_v0alpha1.md

@@ -101,6 +101,10 @@ resource "grafana_apps_rules_alertrule_v0alpha1" "example" {
     notification_settings {
       contact_point = "grafana-default-email"
     }
+    panel_ref = {
+      dashboard_uid = "dashboard123"
+      panel_id      = 5
+    }
   }
 }
 ```
@@ -163,7 +167,7 @@ Optional:
 - `labels` (Map of String) Key-value pairs to attach to the alert rule that can be used in matching, grouping, and routing.
 - `missing_series_evals_to_resolve` (Number) The number of missing series evaluations that must occur before the rule is considered to be resolved.
 - `notification_settings` (Block, Optional) Notification settings for the rule. If specified, it overrides the notification policies. (see [below for nested schema](#nestedblock--spec--notification_settings))
-- `panel_ref` (Dynamic) Reference to a panel that this alert rule is associated with. Should be an object with 'dashboard_uid' (string) and 'panel_id' (number) fields.
+- `panel_ref` (Object) Reference to a panel that this alert rule is associated with. Should be an object with 'dashboard_uid' (string) and 'panel_id' (number) fields. (see [below for nested schema](#nestedatt--spec--panel_ref))
 - `paused` (Boolean) Sets whether the rule should be paused or not.
 - `trigger` (Block, Optional) The trigger configuration for the alert rule. (see [below for nested schema](#nestedblock--spec--trigger))
 
@@ -184,6 +188,15 @@ Optional:
 - `repeat_interval` (String) Minimum time interval for re-sending a notification if an alert is still firing.
 
 
+<a id="nestedatt--spec--panel_ref"></a>
+### Nested Schema for `spec.panel_ref`
+
+Optional:
+
+- `dashboard_uid` (String)
+- `panel_id` (Number)
+
+
 <a id="nestedblock--spec--trigger"></a>
 ### Nested Schema for `spec.trigger`
 

examples/resources/grafana_apps_rules_alertrule_v0alpha1/resource.tf

@@ -86,5 +86,9 @@ resource "grafana_apps_rules_alertrule_v0alpha1" "example" {
     notification_settings {
       contact_point = "grafana-default-email"
     }
+    panel_ref = {
+      dashboard_uid = "dashboard123"
+      panel_id      = 5
+    }
   }
 }

internal/resources/appplatform/alertrule_resource.go

@@ -29,24 +29,24 @@ var alertRuleSpecType = types.ObjectType{
 		"notification_settings":           notificationSettingsType,
 		"annotations":                     types.MapType{ElemType: types.StringType},
 		"labels":                          types.MapType{ElemType: types.StringType},
-		"panel_ref":                       types.DynamicType,
+		"panel_ref":                       panelRefType,
 	},
 }
 
 type AlertRuleSpecModel struct {
-	Title                       types.String  `tfsdk:"title"`
-	Expressions                 types.Map     `tfsdk:"expressions"`
-	Paused                      types.Bool    `tfsdk:"paused"`
-	Trigger                     types.Object  `tfsdk:"trigger"`
-	NoDataState                 types.String  `tfsdk:"no_data_state"`
-	ExecErrState                types.String  `tfsdk:"exec_err_state"`
-	For                         types.String  `tfsdk:"for"`
-	KeepFiringFor               types.String  `tfsdk:"keep_firing_for"`
-	MissingSeriesEvalsToResolve types.Int64   `tfsdk:"missing_series_evals_to_resolve"`
-	NotificationSettings        types.Object  `tfsdk:"notification_settings"`
-	Annotations                 types.Map     `tfsdk:"annotations"`
-	Labels                      types.Map     `tfsdk:"labels"`
-	PanelRef                    types.Dynamic `tfsdk:"panel_ref"`
+	Title                       types.String `tfsdk:"title"`
+	Expressions                 types.Map    `tfsdk:"expressions"`
+	Paused                      types.Bool   `tfsdk:"paused"`
+	Trigger                     types.Object `tfsdk:"trigger"`
+	NoDataState                 types.String `tfsdk:"no_data_state"`
+	ExecErrState                types.String `tfsdk:"exec_err_state"`
+	For                         types.String `tfsdk:"for"`
+	KeepFiringFor               types.String `tfsdk:"keep_firing_for"`
+	MissingSeriesEvalsToResolve types.Int64  `tfsdk:"missing_series_evals_to_resolve"`
+	NotificationSettings        types.Object `tfsdk:"notification_settings"`
+	Annotations                 types.Map    `tfsdk:"annotations"`
+	Labels                      types.Map    `tfsdk:"labels"`
+	PanelRef                    types.Object `tfsdk:"panel_ref"`
 }
 
 var notificationSettingsType = types.ObjectType{
@@ -143,9 +143,10 @@ Manages Grafana Alert Rules.
 						ElementType: types.StringType,
 						Description: "Key-value pairs to attach to the alert rule that can be used in matching, grouping, and routing.",
 					},
-					"panel_ref": schema.DynamicAttribute{
-						Optional:    true,
-						Description: "Reference to a panel that this alert rule is associated with. Should be an object with 'dashboard_uid' (string) and 'panel_id' (number) fields.",
+					"panel_ref": schema.ObjectAttribute{
+						AttributeTypes: panelRefType.AttributeTypes(),
+						Optional:       true,
+						Description:    "Reference to a panel that this alert rule is associated with. Should be an object with 'dashboard_uid' (string) and 'panel_id' (number) fields.",
 					},
 				},
 				SpecBlocks: map[string]schema.Block{
@@ -425,11 +426,9 @@ func saveAlertRuleSpec(ctx context.Context, src *v0alpha1.AlertRule, dst *Resour
 		if d.HasError() {
 			return d
 		}
-		// Convert to dynamic
-		dynamicValue := types.DynamicValue(panelRef)
-		values["panel_ref"] = dynamicValue
+		values["panel_ref"] = panelRef
 	} else {
-		values["panel_ref"] = types.DynamicNull()
+		values["panel_ref"] = types.ObjectNull(panelRefType.AttrTypes)
 	}
 	if len(src.Spec.Expressions) > 0 {
 		// Convert expressions to map[string]string where each string is JSON
@@ -536,15 +535,8 @@ func parseAlertRuleTrigger(ctx context.Context, src types.Object) (v0alpha1.Aler
 	}, diag.Diagnostics{}
 }
 
-func parsePanelRef(ctx context.Context, src types.Dynamic) (v0alpha1.AlertRuleV0alpha1SpecPanelRef, diag.Diagnostics) {
-	panelRefObj, ok := src.UnderlyingValue().(types.Object)
-	if !ok {
-		return v0alpha1.AlertRuleV0alpha1SpecPanelRef{}, diag.Diagnostics{
-			diag.NewErrorDiagnostic("Invalid panel_ref type", "panel_ref must be an object with dashboard_uid and panel_id fields"),
-		}
-	}
-
-	attrs := panelRefObj.Attributes()
+func parsePanelRef(ctx context.Context, src types.Object) (v0alpha1.AlertRuleV0alpha1SpecPanelRef, diag.Diagnostics) {
+	attrs := src.Attributes()
 	dashboardUID, ok := attrs["dashboard_uid"].(types.String)
 	if !ok {
 		return v0alpha1.AlertRuleV0alpha1SpecPanelRef{}, diag.Diagnostics{