applatform: remove dynamic types from alertrule resource using map (#2465)

This dynamic type was preventing generation of crossplane provider tooling as dynamic types are not supported. Follow up to #2426

Object type is also not supported unfortunately. Follow up to #2463

Co-authored-by: William Wernert <[email protected]>

Author: moustafab

docs/resources/apps_rules_alertrule_v0alpha1.md

@@ -103,7 +103,7 @@ resource "grafana_apps_rules_alertrule_v0alpha1" "example" {
     }
     panel_ref = {
       dashboard_uid = "dashboard123"
-      panel_id      = 5
+      panel_id      = "5"
     }
   }
 }
@@ -167,7 +167,7 @@ Optional:
 - `labels` (Map of String) Key-value pairs to attach to the alert rule that can be used in matching, grouping, and routing.
 - `missing_series_evals_to_resolve` (Number) The number of missing series evaluations that must occur before the rule is considered to be resolved.
 - `notification_settings` (Block, Optional) Notification settings for the rule. If specified, it overrides the notification policies. (see [below for nested schema](#nestedblock--spec--notification_settings))
-- `panel_ref` (Object) Reference to a panel that this alert rule is associated with. Should be an object with 'dashboard_uid' (string) and 'panel_id' (number) fields. (see [below for nested schema](#nestedatt--spec--panel_ref))
+- `panel_ref` (Map of String) Reference to a panel that this alert rule is associated with. Should be an object with 'dashboard_uid' (string) and 'panel_id' (number) fields.
 - `paused` (Boolean) Sets whether the rule should be paused or not.
 - `trigger` (Block, Optional) The trigger configuration for the alert rule. (see [below for nested schema](#nestedblock--spec--trigger))
 
@@ -188,15 +188,6 @@ Optional:
 - `repeat_interval` (String) Minimum time interval for re-sending a notification if an alert is still firing.
 
 
-<a id="nestedatt--spec--panel_ref"></a>
-### Nested Schema for `spec.panel_ref`
-
-Optional:
-
-- `dashboard_uid` (String)
-- `panel_id` (Number)
-
-
 <a id="nestedblock--spec--trigger"></a>
 ### Nested Schema for `spec.trigger`
 

examples/resources/grafana_apps_rules_alertrule_v0alpha1/resource.tf

@@ -88,7 +88,7 @@ resource "grafana_apps_rules_alertrule_v0alpha1" "example" {
     }
     panel_ref = {
       dashboard_uid = "dashboard123"
-      panel_id      = 5
+      panel_id      = "5"
     }
   }
 }

internal/resources/appplatform/alertrule_resource.go

@@ -3,6 +3,7 @@ package appplatform
 import (
 	"context"
 	"encoding/json"
+	"strconv"
 
 	"github.com/grafana/grafana/apps/alerting/rules/pkg/apis/alerting/v0alpha1"
 	"github.com/grafana/terraform-provider-grafana/v4/internal/common"
@@ -29,7 +30,7 @@ var alertRuleSpecType = types.ObjectType{
 		"notification_settings":           notificationSettingsType,
 		"annotations":                     types.MapType{ElemType: types.StringType},
 		"labels":                          types.MapType{ElemType: types.StringType},
-		"panel_ref":                       panelRefType,
+		"panel_ref":                       types.MapType{ElemType: types.StringType},
 	},
 }
 
@@ -46,7 +47,7 @@ type AlertRuleSpecModel struct {
 	NotificationSettings        types.Object `tfsdk:"notification_settings"`
 	Annotations                 types.Map    `tfsdk:"annotations"`
 	Labels                      types.Map    `tfsdk:"labels"`
-	PanelRef                    types.Object `tfsdk:"panel_ref"`
+	PanelRef                    types.Map    `tfsdk:"panel_ref"`
 }
 
 var notificationSettingsType = types.ObjectType{
@@ -71,13 +72,6 @@ type NotificationSettingsModel struct {
 	RepeatInterval types.String `tfsdk:"repeat_interval"`
 }
 
-var panelRefType = types.ObjectType{
-	AttrTypes: map[string]attr.Type{
-		"dashboard_uid": types.StringType,
-		"panel_id":      types.Int64Type,
-	},
-}
-
 type PanelRefModel struct {
 	DashboardUID types.String `tfsdk:"dashboard_uid"`
 	PanelID      types.Int64  `tfsdk:"panel_id"`
@@ -143,10 +137,10 @@ Manages Grafana Alert Rules.
 						ElementType: types.StringType,
 						Description: "Key-value pairs to attach to the alert rule that can be used in matching, grouping, and routing.",
 					},
-					"panel_ref": schema.ObjectAttribute{
-						AttributeTypes: panelRefType.AttributeTypes(),
-						Optional:       true,
-						Description:    "Reference to a panel that this alert rule is associated with. Should be an object with 'dashboard_uid' (string) and 'panel_id' (number) fields.",
+					"panel_ref": schema.MapAttribute{
+						ElementType: types.StringType,
+						Optional:    true,
+						Description: "Reference to a panel that this alert rule is associated with. Should be an object with 'dashboard_uid' (string) and 'panel_id' (number) fields.",
 					},
 				},
 				SpecBlocks: map[string]schema.Block{
@@ -422,13 +416,13 @@ func saveAlertRuleSpec(ctx context.Context, src *v0alpha1.AlertRule, dst *Resour
 		values["labels"] = types.MapNull(types.StringType)
 	}
 	if src.Spec.PanelRef != nil {
-		panelRef, d := types.ObjectValueFrom(ctx, panelRefType.AttrTypes, src.Spec.PanelRef)
+		panelRef, d := types.MapValueFrom(ctx, types.StringType, src.Spec.PanelRef)
 		if d.HasError() {
 			return d
 		}
 		values["panel_ref"] = panelRef
 	} else {
-		values["panel_ref"] = types.ObjectNull(panelRefType.AttrTypes)
+		values["panel_ref"] = types.MapNull(types.StringType)
 	}
 	if len(src.Spec.Expressions) > 0 {
 		// Convert expressions to map[string]string where each string is JSON
@@ -535,28 +529,26 @@ func parseAlertRuleTrigger(ctx context.Context, src types.Object) (v0alpha1.Aler
 	}, diag.Diagnostics{}
 }
 
-func parsePanelRef(ctx context.Context, src types.Object) (v0alpha1.AlertRuleV0alpha1SpecPanelRef, diag.Diagnostics) {
-	attrs := src.Attributes()
+func parsePanelRef(ctx context.Context, src types.Map) (v0alpha1.AlertRuleV0alpha1SpecPanelRef, diag.Diagnostics) {
+	attrs := src.Elements()
 	dashboardUID, ok := attrs["dashboard_uid"].(types.String)
 	if !ok {
 		return v0alpha1.AlertRuleV0alpha1SpecPanelRef{}, diag.Diagnostics{
 			diag.NewErrorDiagnostic("Invalid panel_ref.dashboard_uid", "dashboard_uid must be a string"),
 		}
 	}
 
-	panelID, ok := attrs["panel_id"].(types.Number)
-	if !ok {
+	panelIDStr, ok := attrs["panel_id"].(types.String)
+	panelID, err := strconv.ParseInt(panelIDStr.String(), 10, 64)
+	if !ok || err != nil {
 		return v0alpha1.AlertRuleV0alpha1SpecPanelRef{}, diag.Diagnostics{
 			diag.NewErrorDiagnostic("Invalid panel_ref.panel_id", "panel_id must be a number"),
 		}
 	}
 
-	panelIDBigFloat := panelID.ValueBigFloat()
-	panelIDInt64, _ := panelIDBigFloat.Int64()
-
 	return v0alpha1.AlertRuleV0alpha1SpecPanelRef{
 		DashboardUID: dashboardUID.ValueString(),
-		PanelID:      panelIDInt64,
+		PanelID:      panelID,
 	}, diag.Diagnostics{}
 }