Synthetic Monitoring: Restrict invalid labels (#576)

* Synthetic Monitoring: Restrict invalid labels
Restricting label names according to the prometheus data model: https://prometheus.io/docs/concepts/data_model/#metric-names-and-labels
For the value, I found that commas and empty values are disallowed by the SM API
Fixes #541

* Extract banned chars and label name regex

* Use Validate function from SM package

* Remove value validation. Will be fixed in the API

* remove unused var

Author: julienduchesne

grafana/resource_synthetic_monitoring_probe.go

@@ -8,6 +8,7 @@ import (
 	"strconv"
 	"strings"
 
+	"github.com/hashicorp/go-cty/cty"
 	"github.com/hashicorp/terraform-plugin-sdk/v2/diag"
 	"github.com/hashicorp/terraform-plugin-sdk/v2/helper/schema"
 
@@ -80,6 +81,16 @@ Grafana Synthetic Monitoring Agent.
 				Elem: &schema.Schema{
 					Type: schema.TypeString,
 				},
+				ValidateDiagFunc: func(i interface{}, p cty.Path) diag.Diagnostics {
+					for k, vInt := range i.(map[string]interface{}) {
+						v := vInt.(string)
+						lbl := sm.Label{Name: k, Value: v}
+						if err := lbl.Validate(); err != nil {
+							return diag.Errorf(`invalid label "%s=%s": %s`, k, v, err)
+						}
+					}
+					return nil
+				},
 			},
 			"public": {
 				Description: "Public probes are run by Grafana Labs and can be used by all users. Only Grafana Labs managed public probes will be set to `true`.",

grafana/resource_synthetic_monitoring_probe_test.go

@@ -2,6 +2,8 @@ package grafana
 
 import (
 	"context"
+	"fmt"
+	"regexp"
 	"strconv"
 	"testing"
 
@@ -77,3 +79,50 @@ func TestAccResourceSyntheticMonitoringProbe_recreate(t *testing.T) {
 		},
 	})
 }
+
+func TestAccResourceSyntheticMonitoringProbe_InvalidLabels(t *testing.T) {
+	CheckCloudInstanceTestsEnabled(t)
+
+	var steps []resource.TestStep
+	for _, tc := range []struct {
+		cfg string
+		err string
+	}{
+		{
+			cfg: testSyntheticMonitoringProbeLabel("", "any"),
+			err: `invalid label "=any": invalid label name`,
+		},
+		{
+			cfg: testSyntheticMonitoringProbeLabel("bad-label", "any"),
+			err: `invalid label "bad-label=any": invalid label name`,
+		},
+		{
+			cfg: testSyntheticMonitoringProbeLabel("thisisempty", ""),
+			err: `invalid label "thisisempty=": invalid label value`,
+		},
+	} {
+		steps = append(steps, resource.TestStep{
+			Config:      tc.cfg,
+			ExpectError: regexp.MustCompile(tc.err),
+		})
+	}
+
+	resource.Test(t, resource.TestCase{
+		ProviderFactories: testAccProviderFactories,
+		Steps:             steps,
+	})
+}
+
+func testSyntheticMonitoringProbeLabel(name, value string) string {
+	return fmt.Sprintf(`
+resource "grafana_synthetic_monitoring_probe" "main" {
+	name      = "Everest"
+	latitude  = 27.98606
+	longitude = 86.92262
+	region    = "APAC"
+	labels = {
+		"%s" = "%s"
+	}
+}
+`, name, value)
+}