Add resource to install cloud plugin (#424)

* Add resource to install cloud plugin

* Generate docs

* Ensure stack is provisioned before applying plugin

* Update prefix

* Set installation values on create

* Check resource deleted

* Check resource deleted following resource removal

* Fix PR comments

* Remove ID check. We don't use the installation ID

Co-authored-by: Julien Duchesne <[email protected]>

Author: matthewnolf

docs/resources/cloud_plugin_installation.md

@@ -0,0 +1,45 @@
+---
+# generated by https://github.com/hashicorp/terraform-plugin-docs
+page_title: "grafana_cloud_plugin_installation Resource - terraform-provider-grafana"
+subcategory: ""
+description: |-
+  Manages Grafana Cloud Plugin Installations.
+  Plugin Catalog https://grafana.com/grafana/plugins/
+---
+
+# grafana_cloud_plugin_installation (Resource)
+
+Manages Grafana Cloud Plugin Installations.
+
+* [Plugin Catalog](https://grafana.com/grafana/plugins/)
+
+## Example Usage
+
+```terraform
+resource "grafana_cloud_plugin_installation" "test" {
+  stack_slug = "stackname"
+  slug       = "some-plugin"
+  version    = "1.2.3"
+}
+```
+
+<!-- schema generated by tfplugindocs -->
+## Schema
+
+### Required
+
+- `slug` (String) Slug of the plugin to be installed.
+- `stack_slug` (String) The stack id to which the plugin should be installed.
+- `version` (String) Version of the plugin to be installed.
+
+### Optional
+
+- `id` (String) The ID of this resource.
+
+## Import
+
+Import is supported using the following syntax:
+
+```shell
+terraform import grafana_cloud_plugin_installation.plugin_name {{stack_slug}}_{{plugin_slug}}
+```

examples/resources/grafana_cloud_plugin_installation/import.sh

@@ -0,0 +1 @@
+terraform import grafana_cloud_plugin_installation.plugin_name {{stack_slug}}_{{plugin_slug}}

examples/resources/grafana_cloud_plugin_installation/resource.tf

@@ -0,0 +1,5 @@
+resource "grafana_cloud_plugin_installation" "test" {
+  stack_slug = "stackname"
+  slug       = "some-plugin"
+  version    = "1.2.3"
+}

grafana/provider.go

@@ -164,8 +164,9 @@ func Provider(version string) func() *schema.Provider {
 				"grafana_user":                    ResourceUser(),
 
 				// Cloud
-				"grafana_cloud_api_key": ResourceCloudAPIKey(),
-				"grafana_cloud_stack":   ResourceCloudStack(),
+				"grafana_cloud_api_key":             ResourceCloudAPIKey(),
+				"grafana_cloud_plugin_installation": ResourceCloudPluginInstallation(),
+				"grafana_cloud_stack":               ResourceCloudStack(),
 
 				// Synthetic Monitoring
 				"grafana_synthetic_monitoring_check":        ResourceSyntheticMonitoringCheck(),

grafana/resource_cloud_plugin.go

@@ -0,0 +1,99 @@
+package grafana
+
+import (
+	"context"
+	"log"
+	"strings"
+
+	"github.com/hashicorp/terraform-plugin-sdk/v2/diag"
+	"github.com/hashicorp/terraform-plugin-sdk/v2/helper/schema"
+)
+
+func ResourceCloudPluginInstallation() *schema.Resource {
+	return &schema.Resource{
+		Description: `
+Manages Grafana Cloud Plugin Installations.
+
+* [Plugin Catalog](https://grafana.com/grafana/plugins/)
+`,
+		Schema: map[string]*schema.Schema{
+			"stack_slug": {
+				Description: "The stack id to which the plugin should be installed.",
+				Type:        schema.TypeString,
+				Required:    true,
+				ForceNew:    true,
+			},
+			"slug": {
+				Description: "Slug of the plugin to be installed.",
+				Type:        schema.TypeString,
+				Required:    true,
+				ForceNew:    true,
+			},
+			"version": {
+				Description: "Version of the plugin to be installed.",
+				Type:        schema.TypeString,
+				Required:    true,
+				ForceNew:    true,
+			},
+		},
+		CreateContext: resourceCloudPluginInstallationCreate,
+		ReadContext:   resourceCloudPluginInstallationRead,
+		UpdateContext: nil,
+		DeleteContext: resourceCloudPluginInstallationDelete,
+		Importer: &schema.ResourceImporter{
+			StateContext: schema.ImportStatePassthroughContext,
+		},
+	}
+}
+
+func resourceCloudPluginInstallationCreate(ctx context.Context, d *schema.ResourceData, meta interface{}) diag.Diagnostics {
+	client := meta.(*client).gcloudapi
+
+	stackSlug := d.Get("stack_slug").(string)
+	pluginSlug := d.Get("slug").(string)
+	pluginVersion := d.Get("version").(string)
+
+	_, err := client.InstallCloudPlugin(stackSlug, pluginSlug, pluginVersion)
+	if err != nil {
+		return diag.FromErr(err)
+	}
+
+	d.SetId(stackSlug + "_" + pluginSlug)
+
+	return nil
+}
+
+func resourceCloudPluginInstallationRead(ctx context.Context, d *schema.ResourceData, meta interface{}) diag.Diagnostics {
+	client := meta.(*client).gcloudapi
+
+	splitID := strings.SplitN(d.Id(), "_", 2)
+	stackSlug, pluginSlug := splitID[0], splitID[1]
+
+	installation, err := client.GetCloudPluginInstallation(stackSlug, pluginSlug)
+	if err != nil {
+		if strings.HasPrefix(err.Error(), "status: 404") {
+			log.Printf("[WARN] removing plugin %s from state because it no longer exists in stack %s", pluginSlug, stackSlug)
+			d.SetId("")
+			return nil
+		}
+
+		return diag.FromErr(err)
+	}
+
+	d.Set("stack_slug", installation.InstanceSlug)
+	d.Set("slug", installation.PluginSlug)
+	d.Set("version", installation.Version)
+
+	return nil
+}
+
+func resourceCloudPluginInstallationDelete(ctx context.Context, d *schema.ResourceData, meta interface{}) diag.Diagnostics {
+	client := meta.(*client).gcloudapi
+
+	splitID := strings.SplitN(d.Id(), "_", 2)
+	stackSlug, pluginSlug := splitID[0], splitID[1]
+
+	err := client.UninstallCloudPlugin(stackSlug, pluginSlug)
+
+	return diag.FromErr(err)
+}

grafana/resource_cloud_plugin_test.go

@@ -0,0 +1,82 @@
+package grafana
+
+import (
+	"fmt"
+	"testing"
+
+	"github.com/hashicorp/terraform-plugin-sdk/v2/helper/resource"
+	"github.com/hashicorp/terraform-plugin-sdk/v2/terraform"
+)
+
+func TestAccResourceCloudPluginInstallation(t *testing.T) {
+	CheckCloudAPITestsEnabled(t)
+
+	slug := "terraformprovidergrafana"
+	pluginSlug := "aws-datasource-provisioner-app"
+	pluginVersion := "1.7.0"
+
+	resource.Test(t, resource.TestCase{
+		ProviderFactories: testAccProviderFactories,
+		Steps: []resource.TestStep{
+			{
+				Config: testAccGrafanaCloudPluginInstallation(slug, pluginSlug, pluginVersion),
+				Check: resource.ComposeTestCheckFunc(
+					testAccCloudPluginInstallationCheckExists("grafana_cloud_plugin_installation.test-installation", slug, pluginSlug),
+					resource.TestCheckResourceAttrSet("grafana_cloud_plugin_installation.test-installation", "id"),
+					resource.TestCheckResourceAttr("grafana_cloud_plugin_installation.test-installation", "stack_slug", slug),
+					resource.TestCheckResourceAttr("grafana_cloud_plugin_installation.test-installation", "slug", "aws-datasource-provisioner-app"),
+					resource.TestCheckResourceAttr("grafana_cloud_plugin_installation.test-installation", "version", "1.7.0")),
+			},
+			{
+				ResourceName:      "grafana_cloud_plugin_installation.test-installation",
+				ImportState:       true,
+				ImportStateVerify: true,
+			},
+		},
+		CheckDestroy: testAccCloudPluginInstallationDestroy(pluginSlug, pluginVersion),
+	})
+}
+
+func testAccCloudPluginInstallationCheckExists(rn string, stackSlug string, pluginSlug string) resource.TestCheckFunc {
+	return func(s *terraform.State) error {
+		rs, ok := s.RootModule().Resources[rn]
+		if !ok {
+			return fmt.Errorf("resource not found: %s\n %#v", rn, s.RootModule().Resources)
+		}
+
+		if rs.Primary.ID == "" {
+			return fmt.Errorf("resource id not set")
+		}
+
+		client := testAccProvider.Meta().(*client).gcloudapi
+		_, err := client.GetCloudPluginInstallation(stackSlug, pluginSlug)
+		if err != nil {
+			return fmt.Errorf("error getting installation: %s", err)
+		}
+
+		return nil
+	}
+}
+
+func testAccCloudPluginInstallationDestroy(stackSlug string, pluginSlug string) resource.TestCheckFunc {
+	return func(s *terraform.State) error {
+		client := testAccProvider.Meta().(*client).gcloudapi
+
+		installation, err := client.GetCloudPluginInstallation(stackSlug, pluginSlug)
+		if err == nil {
+			return fmt.Errorf("installation `%s` with ID `%d` still exists after destroy", installation.PluginSlug, installation.ID)
+		}
+
+		return nil
+	}
+}
+
+func testAccGrafanaCloudPluginInstallation(stackSlug, name, version string) string {
+	return fmt.Sprintf(`
+		resource "grafana_cloud_plugin_installation" "test-installation" {
+			stack_slug = "%s"
+			slug       = "%s"
+			version    = "%s"
+		}
+	`, stackSlug, name, version)
+}