Cloud: Fix flaky stack creation (#1033)

When creating lots of cloud stacks, the API can sometimes return timeouts
However, the stack may still be creating in the background
Instead of failing immediately, the stack create method can instead try to read the stack before failing

Author: julienduchesne

internal/resources/cloud/resource_cloud_stack.go

@@ -9,6 +9,7 @@ import (
 	"net/url"
 	"regexp"
 	"strconv"
+	"strings"
 	"time"
 
 	gapi "github.com/grafana/grafana-api-golang-client"
@@ -238,16 +239,21 @@ func CreateStack(ctx context.Context, d *schema.ResourceData, meta interface{})
 	}
 
 	stackID, err := client.NewStack(stack)
-	if err != nil && err.Error() == "409 Conflict" {
+	switch {
+	case err != nil && strings.Contains(err.Error(), "409"):
 		return diag.Errorf("Error: A Grafana stack with the name '%s' already exists.", stack.Name)
+	case err != nil:
+		// If we had an error that isn't a 409 (already exists), try to read the stack
+		// Sometimes, the stack is created but the API returns an error (e.g. 504)
+		readStack, readErr := client.StackBySlug(stack.Slug)
+		if readErr != nil {
+			return diag.Errorf("Failed to create stack: %v", err)
+		}
+		d.SetId(strconv.FormatInt(readStack.ID, 10))
+	default:
+		d.SetId(strconv.FormatInt(stackID, 10))
 	}
 
-	if err != nil {
-		return diag.FromErr(err)
-	}
-
-	d.SetId(strconv.FormatInt(stackID, 10))
-
 	if diag := ReadStack(ctx, d, meta); diag != nil {
 		return diag
 	}