Fix bug in PDC data source (#1995)

* Filter to pdc access policies and fix struct issue

* Fix broken link

* Require client to not be nil

* Revert "Require client to not be nil"

This reverts commit b4f1b89.

Author: aangelisc

docs/resources/machine_learning_job.md

@@ -4,15 +4,15 @@ page_title: "grafana_machine_learning_job Resource - terraform-provider-grafana"
 subcategory: "Machine Learning"
 description: |-
   A job defines the queries and model parameters for a machine learning task.
-  See the Grafana Cloud docs https://grafana.com/docs/grafana-cloud/alerting-and-irm/machine-learning/forecasts/models/ for more information
+  See the Grafana Cloud docs https://grafana.com/docs/grafana-cloud/alerting-and-irm/machine-learning/dynamic-alerting/forecasting/config/ for more information
   on available hyperparameters for use in the hyper_params field.
 ---
 
 # grafana_machine_learning_job (Resource)
 
 A job defines the queries and model parameters for a machine learning task.
 
-See [the Grafana Cloud docs](https://grafana.com/docs/grafana-cloud/alerting-and-irm/machine-learning/forecasts/models/) for more information
+See [the Grafana Cloud docs](https://grafana.com/docs/grafana-cloud/alerting-and-irm/machine-learning/dynamic-alerting/forecasting/config/) for more information
 on available hyperparameters for use in the `hyper_params` field.
 
 ## Example Usage

internal/resources/cloud/data_source_private_data_source_connect_network.go

@@ -2,6 +2,7 @@ package cloud
 
 import (
 	"context"
+	"slices"
 
 	"github.com/grafana/terraform-provider-grafana/v3/internal/common"
 	"github.com/hashicorp/terraform-plugin-framework/attr"
@@ -81,7 +82,7 @@ type PDCNetworksDataSourceModel struct {
 	ID                        types.String                       `tfsdk:"id"`
 	NameFilter                types.String                       `tfsdk:"name_filter"`
 	RegionFilter              types.String                       `tfsdk:"region_filter"`
-	PrivateDataSourceNetworks []PDCNetworksDataSourcePolicyModel `tfsdk:"private_data_source_networks"`
+	PrivateDataSourceNetworks []PDCNetworksDataSourcePolicyModel `tfsdk:"private_data_source_connect_networks"`
 }
 
 func (r *PDCNetworksDataSource) Read(ctx context.Context, req datasource.ReadRequest, resp *datasource.ReadResponse) {
@@ -114,6 +115,9 @@ func (r *PDCNetworksDataSource) Read(ctx context.Context, req datasource.ReadReq
 			if data.NameFilter.ValueString() != "" && data.NameFilter.ValueString() != policy.Name {
 				continue
 			}
+			if !slices.Contains(policy.Scopes, "pdc-signing:write") {
+				continue
+			}
 			data.PrivateDataSourceNetworks = append(data.PrivateDataSourceNetworks, PDCNetworksDataSourcePolicyModel{
 				ID:          types.StringValue(*policy.Id),
 				Region:      types.StringValue(region),

internal/resources/machinelearning/resource_job.go

@@ -19,7 +19,7 @@ func resourceJob() *common.Resource {
 		Description: `
 A job defines the queries and model parameters for a machine learning task.
 
-See [the Grafana Cloud docs](https://grafana.com/docs/grafana-cloud/alerting-and-irm/machine-learning/forecasts/models/) for more information
+See [the Grafana Cloud docs](https://grafana.com/docs/grafana-cloud/alerting-and-irm/machine-learning/dynamic-alerting/forecasting/config/) for more information
 on available hyperparameters for use in the ` + "`hyper_params`" + ` field.`,
 
 		CreateContext: checkClient(resourceJobCreate),