Role Datasource: Find hidden roles (#1552)

* Role Datasource: Find hidden roles
Closes #1508
After testing and looking at the role listing params, this seems to me like this is probably the bug
Let's close out the issue with this and we'll see if it's re-opened later :)

* go generate

Author: julienduchesne

docs/data-sources/role.md

@@ -23,6 +23,7 @@ resource "grafana_role" "test" {
   uid         = "test-ds-role-uid"
   version     = 1
   global      = true
+  hidden      = false
 
   permissions {
     action = "org.users:add"

examples/data-sources/grafana_role/data-source.tf

@@ -4,6 +4,7 @@ resource "grafana_role" "test" {
   uid         = "test-ds-role-uid"
   version     = 1
   global      = true
+  hidden      = false
 
   permissions {
     action = "org.users:add"

internal/resources/grafana/data_source_role.go

@@ -31,7 +31,7 @@ func datasourceRole() *schema.Resource {
 
 func dataSourceRoleRead(ctx context.Context, d *schema.ResourceData, meta interface{}) diag.Diagnostics {
 	client, orgID := OAPIClientFromNewOrgResource(meta, d)
-	resp, err := client.AccessControl.ListRoles(access_control.NewListRolesParams(), nil)
+	resp, err := client.AccessControl.ListRoles(access_control.NewListRolesParams().WithIncludeHidden(common.Ref(true)), nil)
 	if err != nil {
 		return diag.FromErr(err)
 	}

internal/resources/grafana/data_source_role_test.go

@@ -1,6 +1,7 @@
 package grafana_test
 
 import (
+	"strconv"
 	"testing"
 
 	"github.com/grafana/grafana-openapi-client-go/models"
@@ -12,30 +13,41 @@ func TestAccDatasourceRole_basic(t *testing.T) {
 	testutils.CheckEnterpriseTestsEnabled(t, ">=9.0.0")
 
 	var role models.RoleDTO
-	checks := []resource.TestCheckFunc{
-		roleCheckExists.exists("grafana_role.test", &role),
-		resource.TestCheckResourceAttr("data.grafana_role.from_name", "name", "test-role"),
-		resource.TestCheckResourceAttr("data.grafana_role.from_name", "description", "test-role description"),
-		resource.TestCheckResourceAttr("data.grafana_role.from_name", "uid", "test-ds-role-uid"),
-		resource.TestCheckResourceAttr("data.grafana_role.from_name", "version", "1"),
-		resource.TestCheckResourceAttr("data.grafana_role.from_name", "global", "true"),
-		resource.TestCheckResourceAttr("data.grafana_role.from_name", "permissions.#", "3"),
-		resource.TestCheckResourceAttr("data.grafana_role.from_name", "permissions.0.action", "org.users:add"),
-		resource.TestCheckResourceAttr("data.grafana_role.from_name", "permissions.0.scope", "users:*"),
-		resource.TestCheckResourceAttr("data.grafana_role.from_name", "permissions.1.action", "org.users:read"),
-		resource.TestCheckResourceAttr("data.grafana_role.from_name", "permissions.1.scope", "users:*"),
-		resource.TestCheckResourceAttr("data.grafana_role.from_name", "permissions.2.action", "org.users:write"),
-		resource.TestCheckResourceAttr("data.grafana_role.from_name", "permissions.2.scope", "users:*"),
-	}
+	for _, hidden := range []bool{false, true} {
+		formatted := strconv.FormatBool(hidden)
+		t.Run("hidden="+formatted, func(t *testing.T) {
+			config := testutils.TestAccExample(t, "data-sources/grafana_role/data-source.tf")
+			if hidden {
+				config = testutils.TestAccExampleWithReplace(t, "data-sources/grafana_role/data-source.tf", map[string]string{
+					`hidden      = false`: `hidden      = true`,
+				})
+			}
 
-	resource.ParallelTest(t, resource.TestCase{
-		ProtoV5ProviderFactories: testutils.ProtoV5ProviderFactories,
-		CheckDestroy:             roleCheckExists.destroyed(&role, nil),
-		Steps: []resource.TestStep{
-			{
-				Config: testutils.TestAccExample(t, "data-sources/grafana_role/data-source.tf"),
-				Check:  resource.ComposeTestCheckFunc(checks...),
-			},
-		},
-	})
+			resource.ParallelTest(t, resource.TestCase{
+				ProtoV5ProviderFactories: testutils.ProtoV5ProviderFactories,
+				CheckDestroy:             roleCheckExists.destroyed(&role, nil),
+				Steps: []resource.TestStep{
+					{
+						Config: config,
+						Check: resource.ComposeTestCheckFunc(
+							roleCheckExists.exists("grafana_role.test", &role),
+							resource.TestCheckResourceAttr("data.grafana_role.from_name", "name", "test-role"),
+							resource.TestCheckResourceAttr("data.grafana_role.from_name", "description", "test-role description"),
+							resource.TestCheckResourceAttr("data.grafana_role.from_name", "uid", "test-ds-role-uid"),
+							resource.TestCheckResourceAttr("data.grafana_role.from_name", "version", "1"),
+							resource.TestCheckResourceAttr("data.grafana_role.from_name", "global", "true"),
+							resource.TestCheckResourceAttr("data.grafana_role.from_name", "hidden", formatted),
+							resource.TestCheckResourceAttr("data.grafana_role.from_name", "permissions.#", "3"),
+							resource.TestCheckResourceAttr("data.grafana_role.from_name", "permissions.0.action", "org.users:add"),
+							resource.TestCheckResourceAttr("data.grafana_role.from_name", "permissions.0.scope", "users:*"),
+							resource.TestCheckResourceAttr("data.grafana_role.from_name", "permissions.1.action", "org.users:read"),
+							resource.TestCheckResourceAttr("data.grafana_role.from_name", "permissions.1.scope", "users:*"),
+							resource.TestCheckResourceAttr("data.grafana_role.from_name", "permissions.2.action", "org.users:write"),
+							resource.TestCheckResourceAttr("data.grafana_role.from_name", "permissions.2.scope", "users:*"),
+						),
+					},
+				},
+			})
+		})
+	}
 }