Alerting Mute Timing: Mute all the time (#1300)

* Alerting Mute Timing: Mute all the time
Closes #649
Currently, it panics because the block is nil

* Linting

Author: julienduchesne

docs/resources/mute_timing.md

@@ -46,7 +46,7 @@ resource "grafana_mute_timing" "my_mute_timing" {
 
 ### Optional
 
-- `intervals` (Block List) The time intervals at which to mute notifications. (see [below for nested schema](#nestedblock--intervals))
+- `intervals` (Block List) The time intervals at which to mute notifications. Use an empty block to mute all the time. (see [below for nested schema](#nestedblock--intervals))
 - `org_id` (String) The Organization ID. If not set, the Org ID defined in the provider block will be used.
 
 ### Read-Only

internal/resources/grafana/resource_alerting_mute_timing.go

@@ -49,7 +49,7 @@ This resource requires Grafana 9.1.0 or later.
 				// Therefore TF will see delete+create instead of modify, which breaks the diff-suppression.
 				Type:        schema.TypeList,
 				Optional:    true,
-				Description: "The time intervals at which to mute notifications.",
+				Description: "The time intervals at which to mute notifications. Use an empty block to mute all the time.",
 				Elem: &schema.Resource{
 					SchemaVersion: 0,
 					Schema: map[string]*schema.Schema{
@@ -248,7 +248,11 @@ func unpackIntervals(raw []interface{}) []*models.TimeInterval {
 	result := make([]*models.TimeInterval, len(raw))
 	for i, r := range raw {
 		interval := models.TimeInterval{}
-		block := r.(map[string]interface{})
+
+		block := map[string]interface{}{}
+		if r != nil {
+			block = r.(map[string]interface{})
+		}
 
 		if vals, ok := block["times"]; ok && vals != nil {
 			vals := vals.([]interface{})

internal/resources/grafana/resource_alerting_mute_timing_test.go

@@ -1,6 +1,7 @@
 package grafana_test
 
 import (
+	"fmt"
 	"testing"
 
 	"github.com/grafana/grafana-openapi-client-go/models"
@@ -69,3 +70,34 @@ func TestAccMuteTiming_basic(t *testing.T) {
 		},
 	})
 }
+
+func TestAccMuteTiming_AllTime(t *testing.T) {
+	testutils.CheckOSSTestsEnabled(t, ">9.0.0")
+
+	var mt models.MuteTimeInterval
+	name := "My Mute Timing"
+
+	resource.ParallelTest(t, resource.TestCase{
+		ProviderFactories: testutils.ProviderFactories,
+		CheckDestroy:      alertingMuteTimingCheckExists.destroyed(&mt, nil),
+		Steps: []resource.TestStep{
+			{
+				Config: fmt.Sprintf(`
+resource "grafana_mute_timing" "my_mute_timing" {
+	  name = "%s"
+	  intervals {}
+}`, name),
+				Check: resource.ComposeTestCheckFunc(
+					alertingMuteTimingCheckExists.exists("grafana_mute_timing.my_mute_timing", &mt),
+					resource.TestCheckResourceAttr("grafana_mute_timing.my_mute_timing", "name", name),
+					resource.TestCheckResourceAttr("grafana_mute_timing.my_mute_timing", "intervals.0.times.#", "0"),
+					resource.TestCheckResourceAttr("grafana_mute_timing.my_mute_timing", "intervals.0.weekdays.#", "0"),
+					resource.TestCheckResourceAttr("grafana_mute_timing.my_mute_timing", "intervals.0.days_of_month.#", "0"),
+					resource.TestCheckResourceAttr("grafana_mute_timing.my_mute_timing", "intervals.0.months.#", "0"),
+					resource.TestCheckResourceAttr("grafana_mute_timing.my_mute_timing", "intervals.0.years.#", "0"),
+					resource.TestCheckNoResourceAttr("grafana_mute_timing.my_mute_timing", "intervals.0.location"),
+				),
+			},
+		},
+	})
+}