Access Control: Allow assigning Edit permissions for data source (#693)

* allow setting edit permissions

* test with Edit permission

* forgot to commit description change

* final doc update

Author: IevaVasiljeva

docs/resources/data_source_permission.md

@@ -40,7 +40,7 @@ resource "grafana_data_source_permission" "fooPermissions" {
   }
   permissions {
     user_id    = 3 // 3 is the admin user in cloud. It can't be queried
-    permission = "Query"
+    permission = "Edit"
   }
 }
 ```
@@ -62,7 +62,7 @@ resource "grafana_data_source_permission" "fooPermissions" {
 
 Required:
 
-- `permission` (String) Permission to associate with item. Must be `Query`.
+- `permission` (String) Permission to associate with item. Options: `Query` or `Edit` (`Edit` can only be used with Grafana v9.2.3+).
 
 Optional:
 

examples/resources/grafana_data_source_permission/resource.tf

@@ -25,6 +25,6 @@ resource "grafana_data_source_permission" "fooPermissions" {
   }
   permissions {
     user_id    = 3 // 3 is the admin user in cloud. It can't be queried
-    permission = "Query"
+    permission = "Edit"
   }
 }

grafana/resource_datasource_permission.go

@@ -54,8 +54,8 @@ func ResourceDatasourcePermission() *schema.Resource {
 						"permission": {
 							Type:         schema.TypeString,
 							Required:     true,
-							ValidateFunc: validation.StringInSlice([]string{"Query"}, false),
-							Description:  "Permission to associate with item. Must be `Query`.",
+							ValidateFunc: validation.StringInSlice([]string{"Query", "Edit"}, false),
+							Description:  "Permission to associate with item. Options: `Query` or `Edit` (`Edit` can only be used with Grafana v9.2.3+).",
 						},
 					},
 				},
@@ -206,15 +206,21 @@ addLoop:
 }
 
 func mapDatasourcePermissionStringToType(permission string) (gapi.DatasourcePermissionType, error) {
-	if permission == "Query" {
+	switch permission {
+	case "Query":
 		return gapi.DatasourcePermissionQuery, nil
+	case "Edit":
+		return gapi.DatasourcePermissionEdit, nil
 	}
 	return 0, fmt.Errorf("unknown datasource permission: %s", permission)
 }
 
 func mapDatasourcePermissionTypeToString(permission gapi.DatasourcePermissionType) (string, error) {
-	if permission == gapi.DatasourcePermissionQuery {
+	switch permission {
+	case gapi.DatasourcePermissionQuery:
 		return "Query", nil
+	case gapi.DatasourcePermissionEdit:
+		return "Edit", nil
 	}
 	return "", fmt.Errorf("unknown permission type: %d", permission)
 }