Performance impact or other potential issues with having multiple client instances.

[RhyG]

I'm curious on if there could potentially be performance issues in a React Native app when creating a new client instance (via new GraphQLClient()) a bunch of times.

Basically I needed a way to dynamically apply authorisation headers that wasn't really supported by any of the other methods. To achieve this I created a custom hook that receives an auth param and creates a new client instance with certain headers if it's true. This mean every query hook which needs to fetch from our GraphQL endpoint creates its own query client instance. Here's a rough example:

const useQuery = (isAuth: boolean) => {
  const client = new GraphQLClient(URL, {
    requestMiddleware: authMiddleware(isAuth), // this will apply auth headers if `isAuth` is true
  });

  // rest of hook
}

// used like this
const useExampleHook = () => {
  const data = useQuery(true);

  return data;
}

Is this opening me up to performance or other issues? I haven't seen any yet, but thought it was worth checking.

[fullyherge]

Curious about this as well. Using a similar method to set different Next revalidation properties for different requests.

[fullyherge]

Like:

const apiClient = (revalidate: number = 120) =>
  new GraphQLClient(endpoint, {
    fetch,
    headers: {
      Authorization: `Bearer ${process.env.DATOCMS_API_TOKEN}`,
      ...(process.env.DATOCMS_ENVIRONMENT
        ? { "X-Environment": process.env.DATOCMS_ENVIRONMENT }
        : {}),
    },
    next: cacheConfig(revalidate),
  });

And then used like:

const data = await apiClient().request(HomePageDocument);

and

const response = await apiClient(3600).request(MetaDocument);

[mxswat]

@RhyG and @fullyherge did you guys found out if creating multiple clients can cause performance issues?

[fullyherge]

As far as I have gathered from my 3-4 projects running a setup like this there seems to be none or very little detrimental effects at least, so it's the solution I'm going with until better support is feasible.

[RhyG]

I haven't observed any issues with it and have had it in production apps for a few months now.