-
Notifications
You must be signed in to change notification settings - Fork 6
autopkg-run.sh - Verbosity levels not working as expected #19
Description
The verbosity of the autopkg-run.sh command doesn't seem to work as expected and I think there might be an error in the code logic.
Essentially every time I run this command it is getting at least two levels of verbosity on the autopkg command and none on the other stuff from the common_framework.sh. After a bit of digging this appears to be because there are quite a few different variables specifying the verbosity.
Line 127 tries to set verbosity based on the value of a $verbose variable but that variable is never defined or set in this script. The common framework also seems to use this $verbose variable but because it is never defined this would explain why there is never any verbose output for these functions regardless of how many -v flags are used.
Additionally Line 254 sets at least one -v which gets added to the end of an AutoPkg command.
The result is there always being at least two -v flags on every AutoPkg run. E.g. autopkg run -v local.recipe.id -v if no -v is used at all with autopkg-run.sh.
There also seems to be some discrepancy between the usage instruction text and the actual argument processing (notably the --quiet which doesn't seem to do anything).
Because this script tends to generate so much verbose output I didn't really want to add it all in here but if it is helpful then I'm happy to you do that.