chore: Cleanup examples-grails3-hibernate5

- `application.yml`: Format properly with 2 spaces and group config settings better. Remove unused config.
- `logback.xml`: Correct faulty pattern
- `build.gradle`: Use correct dependencies and narrow the scopes. Switch from `tomcat-jdbc` to `HikariCP` as this will be the new default. Apply Gradle plugins in subproject instead of having logic and conditions in the root build file apply them - much easier to see what's being applied.
- `BookControllerUnitSpec`: Remove unused imports and bean definition of deprecated `MimeTypesGrailsPlugin`.

Author: matrei

examples/grails3-hibernate5/build.gradle

@@ -1,39 +1,33 @@
-group "examples"
-
-dependencies {
-    implementation "org.springframework.boot:spring-boot-starter-logging"
-    implementation "org.springframework.boot:spring-boot-autoconfigure"
-    implementation "org.springframework.boot:spring-boot-starter-actuator"
-    implementation "org.springframework.boot:spring-boot-starter-tomcat"
-    implementation "jakarta.servlet:jakarta.servlet-api"
-    implementation "org.grails:grails-core"
-    implementation "org.grails:grails-dependencies", {
-        exclude module:'grails-datastore-simple'
-    }
-
-    implementation "org.grails:grails-web-boot"
-    implementation project(":grails-plugin")
-
-    implementation "org.hibernate:hibernate-core-jakarta:$hibernateVersion"
-    implementation "org.hibernate:hibernate-ehcache:$hibernateVersion"
-
-    runtimeOnly "com.bertramlabs.plugins:asset-pipeline-grails"
-    runtimeOnly "com.h2database:h2"
-    runtimeOnly "org.yaml:snakeyaml"
-    runtimeOnly "org.apache.tomcat:tomcat-jdbc"
-    runtimeOnly "org.grails.plugins:fields"
-    runtimeOnly "org.grails.plugins:scaffolding"
-
-    testImplementation("org.grails:grails-gorm-testing-support") {
-        exclude group: "org.spockframework", module: "spock-core"
-    }
-    testImplementation("org.grails:grails-web-testing-support") {
-        exclude group: "org.spockframework", module: "spock-core"
-    }
-
-    integrationTestImplementation testFixtures("org.grails.plugins:geb")
+plugins {
+    id 'com.bertramlabs.asset-pipeline' version '5.0.1'
+    id 'groovy'
+    id 'org.grails.grails-gsp'
+    id 'org.grails.grails-web'
 }
 
+version = rootProject.version
+group = 'examples'
+
+dependencies {
 
-//compileGroovy.groovyOptions.fork = true
-//compileGroovy.groovyOptions.forkOptions.jvmArgs = ['-Xdebug', '-Xrunjdwp:transport=dt_socket,server=y,suspend=y,address=5005']
+    implementation project(':grails-plugin')
+    implementation 'jakarta.persistence:jakarta.persistence-api'
+    implementation 'jakarta.validation:jakarta.validation-api'
+    implementation 'org.grails:grails-core'
+    implementation 'org.grails:grails-plugin-rest'
+    implementation 'org.grails.plugins:gsp'
+
+    runtimeOnly 'com.bertramlabs.plugins:asset-pipeline-grails'
+    runtimeOnly 'com.h2database:h2'
+    runtimeOnly 'com.zaxxer:HikariCP'
+    runtimeOnly 'org.grails.plugins:fields'
+    runtimeOnly 'org.springframework.boot:spring-boot-autoconfigure'
+    runtimeOnly 'org.springframework.boot:spring-boot-starter-logging'
+    runtimeOnly 'org.springframework.boot:spring-boot-starter-tomcat'
+
+    testImplementation 'org.grails:grails-testing-support'
+    testImplementation 'org.grails:grails-gorm-testing-support'
+    testImplementation 'org.grails:grails-web-testing-support'
+
+    integrationTestImplementation testFixtures('org.grails.plugins:geb')
+}

examples/grails3-hibernate5/grails-app/conf/application.yml

@@ -1,121 +1,87 @@
----
-grails:
-    profile: web
-    codegen:
-        defaultPackage: functional.tests
 info:
-    app:
-        name: '@info.app.name@'
-        version: '@info.app.version@'
-        grailsVersion: '@info.app.grailsVersion@'
-spring:
-  groovy:
-        template:
-            check-template-location: false
-  main:
-    allow-circular-references: true
-
+  app:
+    name: '@info.app.name@'
+    version: '@info.app.version@'
+    grailsVersion: '@info.app.grailsVersion@'
 ---
 grails:
-    mime:
-        disable:
-            accept:
-                header:
-                    userAgents:
-                        - Gecko
-                        - WebKit
-                        - Presto
-                        - Trident
-        types:
-            all: '*/*'
-            atom: application/atom+xml
-            css: text/css
-            csv: text/csv
-            form: application/x-www-form-urlencoded
-            html:
-              - text/html
-              - application/xhtml+xml
-            js: text/javascript
-            json:
-              - application/json
-              - text/json
-            multipartForm: multipart/form-data
-            pdf: application/pdf
-            rss: application/rss+xml
-            text: text/plain
-            hal:
-              - application/hal+json
-              - application/hal+xml
-            xml:
-              - text/xml
-              - application/xml
+  profile: web
+  codegen:
+    defaultPackage: functional.tests
+  mime:
+    disable:
+      accept:
+        header:
+          userAgents:
+            - Gecko
+            - WebKit
+            - Presto
+            - Trident
+    types:
+      all: '*/*'
+      atom: application/atom+xml
+      css: text/css
+      csv: text/csv
+      form: application/x-www-form-urlencoded
+      html:
+        - text/html
+        - application/xhtml+xml
+      js: text/javascript
+      json:
+        - application/json
+        - text/json
+      multipartForm: multipart/form-data
+      pdf: application/pdf
+      rss: application/rss+xml
+      text: text/plain
+      hal:
+        - application/hal+json
+        - application/hal+xml
+      xml:
+        - text/xml
+        - application/xml
     urlmapping:
-        cache:
-            maxsize: 1000
-    controllers:
-        defaultScope: singleton
+      cache:
+        maxsize: 1000
     converters:
-        encoding: UTF-8
+      encoding: UTF-8
     views:
-        default:
-            codec: html
-        gsp:
-            encoding: UTF-8
-            htmlcodec: xml
-            codecs:
-                expression: html
-                scriptlets: html
-                taglib: none
-                staticparts: none
+      default:
+        codec: html
+      gsp:
+        encoding: UTF-8
+        htmlcodec: xml
+        codecs:
+          expression: html
+          scriptlets: html
+          taglib: none
+          staticparts: none
 ---
 hibernate:
   configClass: functional.tests.CustomHibernateMappingContextConfiguration
   packagesToScan:
     - another
   cache:
-      queries: false
-      use_second_level_cache: true
-      use_query_cache: false
-      region.factory_class: 'org.hibernate.cache.ehcache.EhCacheRegionFactory'
-endpoints:
-    jmx:
-        unique-names: true
-
+    queries: false
+    use_second_level_cache: true
+    use_query_cache: false
+    region.factory_class: 'org.hibernate.cache.ehcache.EhCacheRegionFactory'
+---
 dataSource:
-    pooled: true
-    jmxExport: true
-    driverClassName: org.h2.Driver
-    username: sa
-    password:
-
+  pooled: true
+  driverClassName: org.h2.Driver
+  username: sa
+  password:
 environments:
-    development:
-        dataSource:
-            dbCreate: create-drop
-            url: jdbc:h2:mem:devDb;LOCK_TIMEOUT=10000;DB_CLOSE_ON_EXIT=FALSE
-    test:
-        dataSource:
-            dbCreate: update
-            url: jdbc:h2:mem:testDb;LOCK_TIMEOUT=10000;DB_CLOSE_ON_EXIT=FALSE
-    production:
-        dataSource:
-            dbCreate: update
-            url: jdbc:h2:./prodDb;LOCK_TIMEOUT=10000;DB_CLOSE_ON_EXIT=FALSE
-            properties:
-                jmxEnabled: true
-                initialSize: 5
-                maxActive: 50
-                minIdle: 5
-                maxIdle: 25
-                maxWait: 10000
-                maxAge: 600000
-                timeBetweenEvictionRunsMillis: 5000
-                minEvictableIdleTimeMillis: 60000
-                validationQuery: SELECT 1
-                validationQueryTimeout: 3
-                validationInterval: 15000
-                testOnBorrow: true
-                testWhileIdle: true
-                testOnReturn: false
-                jdbcInterceptors: ConnectionState
-                defaultTransactionIsolation: 2 # TRANSACTION_READ_COMMITTED
+  development:
+    dataSource:
+      dbCreate: create-drop
+      url: jdbc:h2:mem:devDb;LOCK_TIMEOUT=10000;DB_CLOSE_ON_EXIT=FALSE
+  test:
+    dataSource:
+      dbCreate: update
+      url: jdbc:h2:mem:testDb;LOCK_TIMEOUT=10000;DB_CLOSE_ON_EXIT=FALSE
+  production:
+    dataSource:
+      dbCreate: update
+      url: jdbc:h2:./prodDb;LOCK_TIMEOUT=10000;DB_CLOSE_ON_EXIT=FALSE

examples/grails3-hibernate5/grails-app/conf/logback.xml

@@ -7,7 +7,7 @@
     <appender name="STDOUT" class="ch.qos.logback.core.ConsoleAppender">
         <encoder>
             <charset>UTF-8</charset>
-            <pattern>'%clr(%d{yyyy-MM-dd HH:mm:ss.SSS}){faint} %clr(%5p) %clr(---){faint} %clr([%15.15t]){faint} %clr(%-40.40logger{39}){cyan} %clr(:){faint} %m%n%wex'</pattern>
+            <pattern>%clr(%d{yyyy-MM-dd HH:mm:ss.SSS}){faint} %clr(%5p) %clr(---){faint} %clr([%15.15t]){faint} %clr(%-40.40logger{39}){cyan} %clr(:){faint} %m%n%wex</pattern>
         </encoder>
     </appender>
 

examples/grails3-hibernate5/grails-app/domain/functional/tests/Business.groovy

@@ -1,6 +1,7 @@
 package functional.tests
 
 class Business {
+
     String name
 
     static hasMany = [

examples/grails3-hibernate5/grails-app/domain/functional/tests/Product.groovy

@@ -1,7 +1,5 @@
 package functional.tests
 
-import grails.gorm.annotation.JpaEntity
-
 import jakarta.persistence.Entity
 import jakarta.persistence.GeneratedValue
 import jakarta.persistence.Id
@@ -12,6 +10,7 @@ import jakarta.validation.constraints.Digits
  */
 @Entity
 class Product {
+
     @Id
     @GeneratedValue
     Long myId

examples/grails3-hibernate5/src/test/groovy/functional/tests/BookControllerUnitSpec.groovy

@@ -2,18 +2,12 @@ package functional.tests
 
 import grails.test.hibernate.HibernateSpec
 import grails.testing.web.controllers.ControllerUnitTest
-import org.grails.plugins.web.mime.MimeTypesGrailsPlugin
-import spock.lang.Ignore
 
 /**
  * Created by graemerocher on 24/10/16.
  */
 class BookControllerUnitSpec extends HibernateSpec implements ControllerUnitTest<BookController> {
 
-    def setupSpec() {
-        defineBeans(new MimeTypesGrailsPlugin())
-    }
-
     def setup() {
         def bookService = Mock(BookService)
         bookService.getBook(_) >> { args ->