Skip to content
This repository was archived by the owner on Mar 13, 2025. It is now read-only.

Commit b49f015

Browse files
authored
Remove groovy 4 substitutions which are no longer needed as excludes to geb plugin (#897)
1 parent eb7fc0b commit b49f015

File tree

4 files changed

+5
-43
lines changed

4 files changed

+5
-43
lines changed

build.gradle

Lines changed: 0 additions & 27 deletions
Original file line numberDiff line numberDiff line change
@@ -5,21 +5,11 @@ buildscript {
55
}
66
dependencies {
77
classpath "io.github.gradle-nexus:publish-plugin:$gradleNexusPublishPluginVersion"
8-
classpath "io.github.groovylang.groovydoc:groovydoc-gradle-plugin:$groovydocGradlePluginVersion"
98
classpath "org.grails:grails-gradle-plugin:$grailsGradlePluginVersion"
109
classpath "org.grails.plugins:views-gradle:$viewsGradleVersion"
1110
classpath "org.asciidoctor:asciidoctor-gradle-jvm:$asciidoctorGradleVersion"
1211
classpath "com.github.erdi:webdriver-binaries-gradle-plugin:$webdriverBinariesPluginVersion"
1312
}
14-
15-
configurations.configureEach {
16-
resolutionStrategy.eachDependency { DependencyResolveDetails details ->
17-
if ((details.requested.group == 'org.codehaus.groovy' || details.requested.group == 'org.apache.groovy') && details.requested.name != 'groovy-bom') {
18-
details.useTarget(group: 'org.apache.groovy', name: details.requested.name, version: groovyVersion)
19-
details.because "The dependency coordinates are changed in Apache Groovy 4, plus ensure version"
20-
}
21-
}
22-
}
2313
}
2414

2515
group "org.grails"
@@ -80,23 +70,6 @@ allprojects {
8070
}
8171
}
8272
}
83-
84-
configurations.all {
85-
resolutionStrategy.dependencySubstitution {
86-
substitute module("org.codehaus.groovy:groovy-all") using module("org.apache.groovy:groovy:$groovyVersion")
87-
}
88-
89-
resolutionStrategy.eachDependency { DependencyResolveDetails details ->
90-
if ((details.requested.group == 'org.codehaus.groovy' || details.requested.group == 'org.apache.groovy') && details.requested.name != 'groovy-bom') {
91-
details.useTarget(group: 'org.apache.groovy', name: details.requested.name, version: "$groovyVersion")
92-
details.because "The dependency coordinates are changed in Apache Groovy 4, plus ensure version"
93-
}
94-
95-
if (details.requested.group == "io.micronaut" && details.requested.name == "micronaut-inject-groovy") {
96-
details.useVersion("4.6.1")
97-
}
98-
}
99-
}
10073
}
10174

10275
subprojects { Project subproject ->

examples/grails3-hibernate5/build.gradle

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -33,6 +33,7 @@ dependencies {
3333

3434
testImplementation("org.grails.plugins:geb") {
3535
exclude group: 'org.gebish', module: 'geb-spock'
36+
exclude group: 'org.codehaus.groovy'
3637
}
3738
testImplementation "org.gebish:geb-spock:$gebVersion"
3839
testRuntimeOnly "org.seleniumhq.selenium:selenium-chrome-driver:$seleniumVersion"

examples/grails3-multiple-datasources/build.gradle

Lines changed: 1 addition & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -1,11 +1,5 @@
11
group "examples"
22

3-
configurations.all {
4-
resolutionStrategy.dependencySubstitution {
5-
substitute(module("org.codehaus.groovy:groovy-bom:3.0.8")).using(module("org.apache.groovy:groovy-bom:$groovyVersion"))
6-
}
7-
}
8-
93
dependencies {
104
implementation "org.springframework.boot:spring-boot-starter-logging"
115
implementation "org.springframework.boot:spring-boot-autoconfigure"
@@ -31,6 +25,7 @@ dependencies {
3125
testImplementation "org.grails:grails-gorm-testing-support:$testingSupportVersion"
3226
testImplementation("org.grails.plugins:geb") {
3327
exclude group: 'org.gebish', module: 'geb-spock'
28+
exclude group: 'org.codehaus.groovy'
3429
}
3530
testImplementation "org.gebish:geb-spock:$gebVersion"
3631
testRuntimeOnly "org.seleniumhq.selenium:selenium-chrome-driver:$seleniumVersion"

examples/grails3-schema-per-tenant/build.gradle

Lines changed: 3 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -23,7 +23,9 @@ dependencies {
2323
runtimeOnly "org.grails.plugins:scaffolding:$scaffoldingVersion"
2424

2525
testImplementation "org.grails:grails-gorm-testing-support:$testingSupportVersion"
26-
testImplementation "org.grails.plugins:geb:$gebPluginVersion"
26+
testImplementation "org.grails.plugins:geb:$gebPluginVersion", {
27+
exclude group: 'org.codehaus.groovy'
28+
}
2729
testRuntimeOnly "org.seleniumhq.selenium:selenium-chrome-driver:$seleniumVersion"
2830
testRuntimeOnly "org.seleniumhq.selenium:selenium-firefox-driver:$seleniumVersion"
2931
testRuntimeOnly "org.seleniumhq.selenium:selenium-safari-driver:$seleniumSafariDriverVersion"
@@ -33,15 +35,6 @@ dependencies {
3335
testImplementation "org.seleniumhq.selenium:selenium-support:$seleniumVersion"
3436
}
3537

36-
configurations.all {
37-
resolutionStrategy.eachDependency { DependencyResolveDetails details ->
38-
if ((details.requested.group == 'org.codehaus.groovy')) {
39-
details.useTarget(group: 'org.apache.groovy', name: details.requested.name, version: "$groovyVersion")
40-
details.because "The dependency coordinates are changed in Apache Groovy 4, plus ensure version"
41-
}
42-
}
43-
}
44-
4538
tasks.withType(Test) {
4639
systemProperty "geb.env", System.getProperty('geb.env')
4740
systemProperty "geb.build.reportsDir", reporting.file("geb/integrationTest")

0 commit comments

Comments
 (0)