Skip to content

Missing command code in guidobinaryparser.java #197

@jfkilian

Description

@jfkilian

In guidobinaryparser.java are command codes defined that get later translated into actual java command classes
e.g.

....
        public static char GET_FONT_COLOR_CODE = 42;
	public static char SET_FONT_ALIGN_CODE = 45;
	public static char SELECT_PEN_COLOR_CODE = 49;
...

For a simple gmn that contains a text or fingering tag (most likely any tag that results in a DrawString command) like
[\text<"Hello"> c ] or [\fingering<"1">(c) ] the guidobinaryparser receives in

public static void parseIntoDrawCommands(byte[] data, guidocommandbattery commandBattery) {

a value of head == 46 which is nowhere defined, can't be handled und therefore results in an incomplete score.

It's unclear which actual command is associated with the code 46. Locally we added a workaround with a dummy command routine, that 'eats up' the next 6 bytes:


public static int UnknownCmd(byte[] data, int place, guidocommandbattery commandBattery) {
		place = guidobinaryparser.moveReadPositionByChar(place);
		place = guidobinaryparser.moveReadPositionByFloat(place);

		return place;
	}

It would be great, if someone could add some info which actual command should here be implemented and which information those six bytes represent. My guess would be something like TextFontColor or similar.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions