fix: extend post-completion protection to skip/halt/rewind (#133)

Author: KnorpelSenf

src/engine.ts

@@ -316,6 +316,11 @@ async function replayState(
         return res;
     }
     async function cancel(key?: unknown) {
+        if (complete) {
+            throw new Error(
+                "Cannot perform a cancel operation after the conversation has completed, are you missing an `await`?",
+            );
+        }
         canceled = true;
         interrupted = true;
         message = key;

test/engine.test.ts

@@ -4,6 +4,7 @@ import {
     assert,
     assertEquals,
     assertGreater,
+    assertRejects,
     assertSpyCall,
     assertSpyCalls,
     describe,
@@ -387,4 +388,33 @@ describe("ReplayEngine", () => {
         assertSpyCalls(builder, 2);
         assertEquals(i, 0);
     });
+    it("should throw error if the controls are used after the replay has finished", async () => {
+        let controls: ReplayControls | undefined;
+        const engine = new ReplayEngine((c) => {
+            controls = c;
+        });
+        const res = await engine.play();
+        assertEquals(res.type, "returned");
+        assertRejects(
+            async () => {
+                await controls?.action(() => 0, "");
+            },
+            Error,
+            "missing an `await`",
+        );
+        assertRejects(
+            async () => {
+                await controls?.cancel();
+            },
+            Error,
+            "missing an `await`",
+        );
+        assertRejects(
+            async () => {
+                await controls?.interrupt("");
+            },
+            Error,
+            "missing an `await`",
+        );
+    });
 });