Skip to content

Commit df65beb

Browse files
ailintomsam-m888
authored andcommitted
[Graph View]Display invalid dates when show_full_dates==True[gramps51] (#229)
* Display invalid dates when show_full_dates=true Currently Graph View only displays dates which have at least a valid year. I propose displaying invalid dates (`MOD_TEXTONLY`) as well when the date is not empty and `show_full_dates` is set to `True`. * If no date specified, only show place when show_places Currently the addon erroneously displays the birth/death when `self.show_places==False` and date is empty. Correct behavior: only display place when `self.show_places==True`
1 parent e46358f commit df65beb

File tree

1 file changed

+5
-3
lines changed

1 file changed

+5
-3
lines changed

GraphView/graphview.py

Lines changed: 5 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -2561,18 +2561,20 @@ def get_event_string(self, event):
25612561
"""
25622562
if event:
25632563
place_title = place_displayer.display_event(self.database, event)
2564-
if event.get_date_object().get_year_valid():
2564+
date_object = event.get_date_object()
2565+
#shall we display full date or do we have a valid year to display only year
2566+
if (self.show_full_dates and date_object.get_text()) or date_object.get_year_valid():
25652567
if self.show_full_dates:
25662568
rtrn = '%s' % datehandler.get_date(event)
25672569
else:
2568-
rtrn = '%i' % event.get_date_object().get_year()
2570+
rtrn = '%i' % date_object.get_year()
25692571
# shall we add the place?
25702572
if self.show_places:
25712573
if place_title:
25722574
rtrn += ' - %s' % place_title
25732575
return rtrn
25742576
else:
2575-
if place_title:
2577+
if place_title and self.show_places:
25762578
return place_title
25772579
return ''
25782580

0 commit comments

Comments
 (0)