Fixes for the case where the db default person is gone (#401)

* Fixes for the case where the db default person is gone

* Remove missing import

* Version -> 1.1.8

Author: DavidMStraub

gramps_webapi/_version.py

@@ -18,4 +18,4 @@
 #
 
 # make sure to match this version with the one in apispec.yaml
-__version__ = "1.1.7"
+__version__ = "1.1.8"

gramps_webapi/api/resources/exporters.py

@@ -46,6 +46,7 @@
 )
 from . import ProtectedResource
 from .emit import GrampsJSONEncoder
+from .util import check_fix_default_person
 
 
 class ExportersResource(ProtectedResource, GrampsJSONEncoder):
@@ -118,6 +119,8 @@ def post(self, args: Dict, extension: str) -> Response:
         exporters = get_exporters(extension)
         if not exporters:
             abort(404)
+        if has_permissions({PERM_EDIT_OBJ}):
+            check_fix_default_person(get_db_handle(readonly=False))
         tree = get_tree_from_jwt()
         # remove JWT from args
         options = {k: v for k, v in args.items() if k != "jwt"}

gramps_webapi/api/resources/reports.py

@@ -29,7 +29,7 @@
 from flask import Response, abort, current_app, jsonify, send_file
 from webargs import fields, validate
 
-from ...auth.const import PERM_VIEW_PRIVATE
+from ...auth.const import PERM_EDIT_OBJ, PERM_VIEW_PRIVATE
 from ...const import MIME_TYPES
 from ..auth import has_permissions
 from ..report import check_report_id_exists, get_reports, run_report
@@ -42,6 +42,7 @@
 )
 from . import ProtectedResource
 from .emit import GrampsJSONEncoder
+from .util import check_fix_default_person
 
 
 class ReportsResource(ProtectedResource, GrampsJSONEncoder):
@@ -50,6 +51,8 @@ class ReportsResource(ProtectedResource, GrampsJSONEncoder):
     @use_args({}, location="query")
     def get(self, args: Dict) -> Response:
         """Get all available report attributes."""
+        if has_permissions({PERM_EDIT_OBJ}):
+            check_fix_default_person(get_db_handle(readonly=False))
         reports = get_reports(get_db_handle())
         return self.response(200, reports)
 
@@ -60,6 +63,8 @@ class ReportResource(ProtectedResource, GrampsJSONEncoder):
     @use_args({}, location="query")
     def get(self, args: Dict, report_id: str) -> Response:
         """Get specific report attributes."""
+        if has_permissions({PERM_EDIT_OBJ}):
+            check_fix_default_person(get_db_handle(readonly=False))
         reports = get_reports(get_db_handle(), report_id=report_id)
         if not reports:
             abort(404)
@@ -90,6 +95,9 @@ def get(self, args: Dict, report_id: str) -> Response:
         if "of" in report_options:
             abort(422)
 
+        if has_permissions({PERM_EDIT_OBJ}):
+            check_fix_default_person(get_db_handle(readonly=False))
+
         file_name, file_type = run_report(
             db_handle=get_db_handle(),
             report_id=report_id,
@@ -121,6 +129,8 @@ def post(self, args: Dict, report_id: str) -> Response:
                 abort(400)
         if "of" in report_options:
             abort(422)
+        if has_permissions({PERM_EDIT_OBJ}):
+            check_fix_default_person(get_db_handle(readonly=False))
         tree = get_tree_from_jwt()
         task = run_task(
             generate_report,

gramps_webapi/api/resources/transactions.py

@@ -90,6 +90,11 @@ def post(self, args) -> Response:
                         new_obj = from_json(json.dumps(new_data))
                     if trans_type == "delete":
                         self.handle_delete(trans, class_name, handle)
+                        if (
+                            class_name == "Person"
+                            and handle == db_handle.get_default_handle()
+                        ):
+                            db_handle.set_default_person_handle(None)
                     elif trans_type == "add":
                         self.handle_add(trans, class_name, new_obj)
                     elif trans_type == "update":

gramps_webapi/api/resources/util.py

@@ -1303,3 +1303,24 @@ def run_import_media_archive(
         "uploaded": len(to_upload) - num_failures,
         "failures": num_failures,
     }
+
+
+def check_fix_default_person(db_handle: Union[DbReadBase, DbWriteBase]) -> None:
+    """If the db is writable, check if the default person still exists.
+
+    If it doesn't exist, set the default person to None.
+    """
+    if not isinstance(db_handle, DbWriteBase):
+        # not writable
+        return None
+    handle = db_handle.get_default_handle()
+    if not handle:
+        # default person is already empty
+        return None
+    if db_handle.has_person_handle(handle):
+        # default person exists
+        return None
+    # OK, we have a problem - default person is not empty but does not exist
+    # - set to empty
+    db_handle.set_default_person_handle(None)
+    return None

gramps_webapi/data/apispec.yaml

@@ -8,7 +8,7 @@ info:
 
 
     * More about Gramps and the numerous features it provides for genealogists can be found at https://gramps-project.org
-  version: "1.1.7"  # make sure to match this version with the one in _version.py
+  version: "1.1.8"  # make sure to match this version with the one in _version.py
   license:
     name: "GNU Affero General Public License v3.0"
     url: "http://www.gnu.org/licenses/agpl-3.0.html"