Refactor /api/relations and add unit tests (Closes #47) #65
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
Looks good! Concerning Could you add a unit test for |
Collaborator
Author
Probably, but this might need to get refactored again at some point, I am unsure. I did not realize before but if I recall there appear to be plugin relationship calculators for different languages. I'm not sure how this and they are related.
I will look at it. |
cdhorn
force-pushed
the
relation-tests
branch
from
3029137 to
04638d1
Compare
cdhorn
force-pushed
the
relation-tests
branch
from
04638d1 to
836f311
Compare
Collaborator
Author
|
Rebased. Unsure if locale test I added should do anything more specific than it is. |
Member
|
Perfect. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This removes ?all parm and adds /all in path as response formats differed which was not clean. Includes unit tests and apispec.yaml update.
Now wondering if I should have just added this to PR #60