get_wval_limb usage

Author: BenasKc

kzg/src/msm/strauss.rs

@@ -1,3 +1,4 @@
+use crate::msm::pippenger_utils::get_wval_limb;
 use crate::{Fr, G1Affine, G1Fp, G1GetFp, G1Mul, G1ProjAddAffine, G1};
 use alloc::vec::Vec;
 use core::marker::PhantomData;
@@ -297,15 +298,15 @@ where
         // Convert scalars to scalar limbs for bit access
         let scalar_values = scalars.iter().map(TFr::to_scalar).collect::<Vec<_>>();
 
-        // Find the maximum bit position across all scalars (not per chunk)
+        // Find the maximum bit position across all scalars
         let mut global_max_bit = 0usize;
         for s in &scalar_values {
             for (limb_idx, &limb) in s.data.iter().enumerate().rev() {
                 if limb != 0 {
                     let bit_pos = 63 - limb.leading_zeros() as usize;
-                    let global_bit = limb_idx * 64 + bit_pos;
-                    if global_bit > global_max_bit {
-                        global_max_bit = global_bit;
+                    let scalar_bit = limb_idx * 64 + bit_pos;
+                    if scalar_bit > global_max_bit {
+                        global_max_bit = scalar_bit;
                     }
                     break;
                 }
@@ -319,9 +320,6 @@ where
             // Double accumulator unconditionally
             accumulator.dbl_assign();
 
-            let limb_idx = bit / 64;
-            let bit_in_limb = bit % 64;
-
             // Process each chunk at this bit position
             let mut pt_idx = 0usize;
             for table in chunk_tables.iter() {
@@ -343,10 +341,9 @@ where
                     }
 
                     let s = &scalar_values[scalar_idx];
-                    if limb_idx < s.data.len() {
-                        if ((s.data[limb_idx] >> bit_in_limb) & 1) != 0 {
-                            mask |= 1 << i;
-                        }
+                    // Extract single bit at position 'bit' from scalar
+                    if (get_wval_limb(s, bit, 1) & 1) != 0 {
+                        mask |= 1 << i;
                     }
                 }