fix: avoid reloading files to pcx (foundry-rs#11076)

* fix: avoid reuploading files (without lang check)

* improve docs

Author: 0xrusowsky

crates/lint/src/linter/mod.rs

@@ -29,6 +29,10 @@ use crate::inline_config::InlineConfig;
 /// - `init`: Creates a new solar `Session` with the appropriate linter configuration.
 /// - `early_lint`: Scans the source files (using the AST) emitting a diagnostic for lints found.
 /// - `late_lint`: Scans the source files (using the HIR) emitting a diagnostic for lints found.
+///
+/// # Note:
+///
+/// - For `early_lint` and `late_lint`, the `ParsingContext` should have the sources pre-loaded.
 pub trait Linter: Send + Sync + Clone {
     type Language: Language;
     type Lint: Lint;

crates/lint/src/sol/mod.rs

@@ -199,13 +199,12 @@ impl Linter for SolidityLinter {
         sess
     }
 
-    /// Run AST-based lints
-    fn early_lint<'sess>(&self, input: &[PathBuf], mut pcx: ParsingContext<'sess>) {
+    /// Run AST-based lints.
+    ///
+    /// Note: the `ParsingContext` should already have the sources loaded.
+    fn early_lint<'sess>(&self, input: &[PathBuf], pcx: ParsingContext<'sess>) {
         let sess = pcx.sess;
         _ = sess.enter_parallel(|| -> Result<(), diagnostics::ErrorGuaranteed> {
-            // Load all files into the parsing ctx
-            pcx.load_files(input)?;
-
             // Parse the sources
             let ast_arena = solar_sema::thread_local::ThreadLocal::new();
             let ast_result = pcx.parse(&ast_arena);
@@ -223,13 +222,12 @@ impl Linter for SolidityLinter {
         });
     }
 
-    /// Run HIR-based lints
-    fn late_lint<'sess>(&self, input: &[PathBuf], mut pcx: ParsingContext<'sess>) {
+    /// Run HIR-based lints.
+    ///
+    /// Note: the `ParsingContext` should already have the sources loaded.
+    fn late_lint<'sess>(&self, input: &[PathBuf], pcx: ParsingContext<'sess>) {
         let sess = pcx.sess;
         _ = sess.enter_parallel(|| -> Result<(), diagnostics::ErrorGuaranteed> {
-            // Load all files into the parsing ctx
-            pcx.load_files(input)?;
-
             // Parse and lower to HIR
             let hir_arena = solar_sema::thread_local::ThreadLocal::new();
             let hir_result = pcx.parse_and_lower(&hir_arena);