Make a static methods

Author: KrzysztofPajak

src/Business/Grand.Business.Authentication/Services/TwoFactorAuthenticationService.cs

@@ -87,7 +87,7 @@ await _customerService.UpdateUserField(customer, SystemCustomerFieldNames.TwoFac
         return model;
     }
 
-    private string PrepareRandomCode()
+    private static string PrepareRandomCode()
     {
         var generator = new Random();
         return generator.Next(0, 999999).ToString("D6");

src/Business/Grand.Business.Catalog/Services/ExportImport/BrandImportDataObject.cs

@@ -81,7 +81,7 @@ private async Task UpdateBrandData(BrandDto brandDto, Brand brand)
         await _slugService.SaveSlug(brand, seName, "");
     }
 
-    private bool ValidBrand(Brand brand)
+    private static bool ValidBrand(Brand brand)
     {
         return !string.IsNullOrEmpty(brand.Name);
     }

src/Business/Grand.Business.Catalog/Services/ExportImport/CategoryImportDataObject.cs

@@ -86,7 +86,7 @@ private async Task UpdateCategoryData(CategoryDto categoryDto, Category category
         await _slugService.SaveSlug(category, seName, "");
     }
 
-    private bool ValidCategory(Category category)
+    private static bool ValidCategory(Category category)
     {
         return !string.IsNullOrEmpty(category.Name);
     }

src/Business/Grand.Business.Catalog/Services/ExportImport/CollectionImportDataObject.cs

@@ -83,7 +83,7 @@ private async Task UpdateCollectionData(CollectionDto collectionDto, Collection
         await _slugService.SaveSlug(collection, sename, "");
     }
 
-    private bool ValidCollection(Collection collection)
+    private static bool ValidCollection(Collection collection)
     {
         return !string.IsNullOrEmpty(collection.Name);
     }

src/Business/Grand.Business.Catalog/Services/ExportImport/ProductImportDataObject.cs

@@ -265,7 +265,7 @@ private async Task PrepareProductPictures(ProductDto productDto, Product product
         }
     }
 
-    private bool ValidProduct(Product product)
+    private static bool ValidProduct(Product product)
     {
         return !string.IsNullOrEmpty(product.Name);
     }

src/Business/Grand.Business.Catalog/Startup/StartupApplication.cs

@@ -44,7 +44,7 @@ public void Configure(WebApplication application, IWebHostEnvironment webHostEnv
     public int Priority => 100;
     public bool BeforeConfigure => false;
 
-    private void RegisterCatalogService(IServiceCollection serviceCollection)
+    private static void RegisterCatalogService(IServiceCollection serviceCollection)
     {
         serviceCollection.AddScoped<IOutOfStockSubscriptionService, OutOfStockSubscriptionService>();
         serviceCollection.AddScoped<ICategoryService, CategoryService>();
@@ -77,21 +77,21 @@ private void RegisterCatalogService(IServiceCollection serviceCollection)
         serviceCollection.AddScoped<IMeasureService, MeasureService>();
     }
 
-    private void RegisterDiscountsService(IServiceCollection serviceCollection)
+    private static void RegisterDiscountsService(IServiceCollection serviceCollection)
     {
         serviceCollection.AddScoped<IDiscountService, DiscountService>();
         serviceCollection.AddScoped<IDiscountValidationService, DiscountValidationService>();
         serviceCollection.AddScoped<IDiscountProviderLoader, DiscountProviderLoader>();
     }
 
-    private void RegisterTaxService(IServiceCollection serviceCollection)
+    private static void RegisterTaxService(IServiceCollection serviceCollection)
     {
         serviceCollection.AddScoped<ITaxService, TaxService>();
         serviceCollection.AddScoped<IVatService, VatService>();
         serviceCollection.AddScoped<ITaxCategoryService, TaxCategoryService>();
     }
 
-    private void RegisterExportImport(IServiceCollection serviceCollection)
+    private static void RegisterExportImport(IServiceCollection serviceCollection)
     {
         serviceCollection.AddScoped<ISchemaProperty<Brand>, BrandSchemaProperty>();
         serviceCollection.AddScoped<ISchemaProperty<Category>, CategorySchemaProperty>();

src/Business/Grand.Business.Checkout/Commands/Handlers/Orders/PrepareOrderCodeCommandHandler.cs

@@ -24,7 +24,7 @@ public async Task<string> Handle(PrepareOrderCodeCommand request, CancellationTo
         return await Task.FromResult(code);
     }
 
-    private string RandomString(int length)
+    private static string RandomString(int length)
     {
         const string chars = "ABCDEFGHIJKLMNOPQRSTUVWXYZ0123456789";
         return new string(Enumerable.Repeat(chars, length)

src/Business/Grand.Business.Checkout/Startup/StartupApplication.cs

@@ -38,7 +38,7 @@ public void Configure(WebApplication application, IWebHostEnvironment webHostEnv
     public bool BeforeConfigure => false;
 
 
-    private void RegisterOrdersService(IServiceCollection serviceCollection)
+    private static void RegisterOrdersService(IServiceCollection serviceCollection)
     {
         serviceCollection.AddScoped<ILoyaltyPointsService, LoyaltyPointsService>();
         serviceCollection.AddScoped<IGiftVoucherService, GiftVoucherService>();
@@ -56,13 +56,13 @@ private void RegisterOrdersService(IServiceCollection serviceCollection)
         serviceCollection.AddScoped<IOrderReportService, OrderReportService>();
     }
 
-    private void RegisterPaymentsService(IServiceCollection serviceCollection)
+    private static void RegisterPaymentsService(IServiceCollection serviceCollection)
     {
         serviceCollection.AddScoped<IPaymentService, PaymentService>();
         serviceCollection.AddScoped<IPaymentTransactionService, PaymentTransactionService>();
     }
 
-    private void RegisterShippingService(IServiceCollection serviceCollection)
+    private static void RegisterShippingService(IServiceCollection serviceCollection)
     {
         serviceCollection.AddScoped<IShipmentService, ShipmentService>();
         serviceCollection.AddScoped<IShippingService, ShippingService>();
@@ -72,7 +72,7 @@ private void RegisterShippingService(IServiceCollection serviceCollection)
         serviceCollection.AddScoped<IShippingMethodService, ShippingMethodService>();
     }
 
-    private void RegisterExportImport(IServiceCollection serviceCollection)
+    private static void RegisterExportImport(IServiceCollection serviceCollection)
     {
         serviceCollection.AddScoped<ISchemaProperty<Order>, OrderSchemaProperty>();
     }

src/Business/Grand.Business.Common/Services/ExportImport/ExcelExportProvider.cs

@@ -55,7 +55,7 @@ public virtual byte[] BuilderExportToByte()
     /// </summary>
     /// <param name="sheet"></param>
     /// <param name="properties"></param>
-    private void WriteCaption<T>(ISheet sheet, PropertyByName<T>[] properties)
+    private static void WriteCaption<T>(ISheet sheet, PropertyByName<T>[] properties)
     {
         var row = sheet.CreateRow(0);
         foreach (var caption in properties)
@@ -69,7 +69,7 @@ private void WriteCaption<T>(ISheet sheet, PropertyByName<T>[] properties)
     /// <param name="idrow">Row index</param>
     /// <param name="properties"></param>
     /// <param name="sheet"></param>
-    private void WriteToXlsx<T>(PropertyByName<T>[] properties, ISheet sheet, T items, int idrow)
+    private static void WriteToXlsx<T>(PropertyByName<T>[] properties, ISheet sheet, T items, int idrow)
     {
         var row = sheet.CreateRow(idrow);
         foreach (var prop in properties)

src/Business/Grand.Business.Common/Services/Security/EncryptionService.cs

@@ -95,7 +95,7 @@ public virtual string DecryptText(string cipherText, string encryptionPrivateKey
 
     #region Utilities
 
-    private byte[] EncryptTextToMemory(string data, byte[] key, byte[] iv)
+    private static byte[] EncryptTextToMemory(string data, byte[] key, byte[] iv)
     {
         using var ms = new MemoryStream();
         using (var cs = new CryptoStream(ms, TripleDES.Create().CreateEncryptor(key, iv), CryptoStreamMode.Write))
@@ -108,7 +108,7 @@ private byte[] EncryptTextToMemory(string data, byte[] key, byte[] iv)
         return ms.ToArray();
     }
 
-    private string DecryptTextFromMemory(byte[] data, byte[] key, byte[] iv)
+    private static string DecryptTextFromMemory(byte[] data, byte[] key, byte[] iv)
     {
         using var ms = new MemoryStream(data);
         using var cs = new CryptoStream(ms, TripleDES.Create().CreateDecryptor(key, iv), CryptoStreamMode.Read);