Fixes for pylint

Author: grantjenks

.pylintrc

@@ -127,7 +127,15 @@ disable=print-statement,
         dict-items-not-iterating,
         dict-keys-not-iterating,
         dict-values-not-iterating,
-        inconsistent-return-statements
+        inconsistent-return-statements,
+        no-name-in-module,
+        invalid-name,
+        abstract-method,
+        protected-access,
+        redefined-argument-from-local,
+        no-staticmethod-decorator,
+        super-init-not-called,
+        ungrouped-imports
 
 # Enable the message, report, category or checker with the given id(s). You can
 # either give multiple identifier separated by comma (,) or put this option
@@ -218,7 +226,10 @@ contextmanager-decorators=contextlib.contextmanager
 # List of members which are set dynamically and missed by pylint inference
 # system, and so shouldn't trigger E1101 when accessed. Python regular
 # expressions are accepted.
-generated-members=
+generated-members=bisect_key_left,
+                  bisect_key_right,
+                  bisect_key,
+                  irange_key
 
 # Tells whether missing members accessed in mixin class should be ignored. A
 # mixin class is detected if its name ends with "mixin" (case insensitive).
@@ -335,7 +346,7 @@ ignore-docstrings=yes
 ignore-imports=no
 
 # Minimum lines number of a similarity.
-min-similarity-lines=4
+min-similarity-lines=6
 
 
 [BASIC]
@@ -518,7 +529,7 @@ max-branches=25
 max-locals=30
 
 # Maximum number of parents for a class (see R0901).
-max-parents=7
+max-parents=10
 
 # Maximum number of public methods for a class (see R0904).
 max-public-methods=20

README.rst

@@ -3,11 +3,9 @@ Python Sorted Containers
 
 .. todo::
 
-   * Add __delitem__ to sorted dict views?
-   * Rename github repo
    * Update coverage
-   * Pass pylint
    * Update development page with test and coverage output.
+   * Rename github repo
    * Replace bintrees in
      * https://github.com/astropy/astropy
      * https://github.com/netzob/netzob

docs/sorteddict.rst

@@ -67,7 +67,6 @@ SortedItemsView
    :show-inheritance:
 
    .. automethod:: __getitem__
-   .. automethod:: __delitem__
 
 
 SortedValuesView
@@ -77,4 +76,3 @@ SortedValuesView
    :show-inheritance:
 
    .. automethod:: __getitem__
-   .. automethod:: __delitem__

sortedcontainers/sorteddict.py

@@ -333,6 +333,7 @@ def values(self):
 
 
     class _NotGiven(object):
+        # pylint: disable=too-few-public-methods
         def __repr__(self):
             return '<not-given>'
 

sortedcontainers/sortedlist.py

@@ -13,6 +13,7 @@
 * :class:`SortedKeyList`
 
 """
+# pylint: disable=too-many-lines
 from __future__ import print_function
 
 from bisect import bisect_left, bisect_right, insort
@@ -30,9 +31,9 @@
 from sys import hexversion
 
 if hexversion < 0x03000000:
-    from itertools import imap as map
-    from itertools import izip as zip
-    reduce = reduce
+    from itertools import imap as map  # pylint: disable=redefined-builtin
+    from itertools import izip as zip  # pylint: disable=redefined-builtin
+    reduce = reduce  # pylint: disable=undefined-variable
     try:
         from thread import get_ident
     except ImportError:
@@ -49,6 +50,7 @@
 
 def recursive_repr(fillvalue='...'):
     "Decorator to make a repr function return fillvalue for a recursive call."
+    # pylint: disable=missing-docstring
     # Copied from reprlib in Python 3
     # https://hg.python.org/cpython/file/3.6/Lib/reprlib.py
 
@@ -185,6 +187,7 @@ def __new__(cls, iterable=None, key=None):
         :return: sorted list or sorted-key list instance
 
         """
+        # pylint: disable=unused-argument
         if key is None:
             return object.__new__(cls)
         else:

sortedcontainers/sortedset.py

@@ -435,6 +435,7 @@ def pop(self, index=-1):
         :raises IndexError: if index is out of range
 
         """
+        # pylint: disable=arguments-differ
         value = self._list.pop(index)
         self._set.remove(value)
         return value