Skip to content

Commit fe8ea5b

Browse files
committed
create constant for query keyword
1 parent 8a007ab commit fe8ea5b

File tree

2 files changed

+7
-2
lines changed

2 files changed

+7
-2
lines changed

src/main/java/com/intuit/graphql/orchestrator/resolverdirective/FieldResolverDirectiveUtil.java

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -28,6 +28,9 @@ public class FieldResolverDirectiveUtil {
2828
public static final String RESOLVER_DIRECTIVE_NAME = "resolver";
2929
public static final String FIELD_REFERENCE_PREFIX = "$";
3030

31+
public static final String FQN_KEYWORD_QUERY = "query";
32+
public static final char FQN_FIELD_SEPARATOR = '.';
33+
3134
public static final CharSequence OPERATION_NAME_SEPARATOR = "_";
3235
public static final CharSequence RESOLVER_DIRECTIVE_QUERY_NAME = "Resolver_Directive_Query";
3336

src/main/java/com/intuit/graphql/orchestrator/schema/transform/FieldResolverTransformerPostMerge.java

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,7 @@
11
package com.intuit.graphql.orchestrator.schema.transform;
22

3+
import static com.intuit.graphql.orchestrator.resolverdirective.FieldResolverDirectiveUtil.FQN_FIELD_SEPARATOR;
4+
import static com.intuit.graphql.orchestrator.resolverdirective.FieldResolverDirectiveUtil.FQN_KEYWORD_QUERY;
35
import static com.intuit.graphql.orchestrator.utils.XtextGraphUtils.addToCodeRegistry;
46
import static com.intuit.graphql.orchestrator.utils.XtextTypeUtils.createNamedType;
57
import static com.intuit.graphql.orchestrator.utils.XtextTypeUtils.getFieldDefinitions;
@@ -198,9 +200,9 @@ private void replacePlaceholderTypeWithActual(FieldResolverContext fieldResolver
198200

199201
private FieldDefinition getFieldDefinitionByFQN(final String queryFieldFQN, XtextGraph xtextGraph) {
200202

201-
String queryFieldFQNNoQuery = StringUtils.removeStart(queryFieldFQN ,"query."); // remove if exists
203+
String queryFieldFQNNoQuery = StringUtils.removeStart(queryFieldFQN ,FQN_KEYWORD_QUERY + FQN_FIELD_SEPARATOR); // remove if exists
202204

203-
String[] queryFieldFQNTokens = StringUtils.split(queryFieldFQNNoQuery, '.');
205+
String[] queryFieldFQNTokens = StringUtils.split(queryFieldFQNNoQuery, FQN_FIELD_SEPARATOR);
204206
if (ArrayUtils.isEmpty(queryFieldFQNTokens)) {
205207
String errorMessage = String.format("Failed to tokenize queryFieldFQN. queryFieldFQN=%s", queryFieldFQN);
206208
throw new IllegalArgumentException(errorMessage);

0 commit comments

Comments
 (0)