Skip to content

Commit 3eb9500

Browse files
committed
Rename "ival" to "code"
1 parent 089a99b commit 3eb9500

File tree

6 files changed

+27
-27
lines changed

6 files changed

+27
-27
lines changed

docs/source/01-decode.ipynb

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -45,7 +45,7 @@
4545
{
4646
"data": {
4747
"text/plain": [
48-
"FormatInfo(name='format_info_ocp_e5m2', k=8, precision=3, emax=15, has_nz=True, has_infs=True, num_high_nans=3, has_subnormals=True, is_signed=True, is_twos_complement=False)"
48+
"FormatInfo(name='ocp_e5m2', k=8, precision=3, emax=15, has_nz=True, has_infs=True, num_high_nans=3, has_subnormals=True, is_signed=True, is_twos_complement=False)"
4949
]
5050
},
5151
"execution_count": 2,
@@ -100,7 +100,7 @@
100100
" <th>fclass</th>\n",
101101
" </tr>\n",
102102
" <tr>\n",
103-
" <th>ival</th>\n",
103+
" <th>code</th>\n",
104104
" <th></th>\n",
105105
" <th></th>\n",
106106
" <th></th>\n",
@@ -228,7 +228,7 @@
228228
],
229229
"text/plain": [
230230
" fval exp expval significand fsignificand signbit \\\n",
231-
"ival \n",
231+
"code \n",
232232
"0 0.000000e+00 0 -14 0 0.00 0 \n",
233233
"1 1.525879e-05 0 -14 1 0.25 0 \n",
234234
"2 3.051758e-05 0 -14 2 0.50 0 \n",
@@ -242,7 +242,7 @@
242242
"255 NaN 31 16 3 1.75 1 \n",
243243
"\n",
244244
" fclass \n",
245-
"ival \n",
245+
"code \n",
246246
"0 FloatClass.ZERO \n",
247247
"1 FloatClass.SUBNORMAL \n",
248248
"2 FloatClass.SUBNORMAL \n",
@@ -266,7 +266,7 @@
266266
"source": [
267267
"fmt = format_info_ocp_e5m2\n",
268268
"vals = [decode_float(fmt, i) for i in range(256)]\n",
269-
"DataFrame(vals).set_index(\"ival\")"
269+
"DataFrame(vals).set_index(\"code\")"
270270
]
271271
},
272272
{
@@ -393,7 +393,7 @@
393393
"name": "python",
394394
"nbconvert_exporter": "python",
395395
"pygments_lexer": "ipython3",
396-
"version": "3.10.14"
396+
"version": "3.10.0"
397397
}
398398
},
399399
"nbformat": 4,

docs/source/03-value-tables.ipynb

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -187,7 +187,7 @@
187187
" text = []\n",
188188
"\n",
189189
" # 0x45 0_1000_101\n",
190-
" text.append(f\"0x{fv.ival:02x} {str_bits_with_underscores(fi, fv)}\")\n",
190+
" text.append(f\"0x{fv.code:02x} {str_bits_with_underscores(fi, fv)}\")\n",
191191
"\n",
192192
" finite_nonzero = np.isfinite(fv.fval) and fv.fval != 0\n",
193193
"\n",
@@ -212,7 +212,7 @@
212212
" return \" = \".join(text)\n",
213213
"\n",
214214
"\n",
215-
"for fi in (format_info_p3109(4), format_info_p3109(1)):\n",
215+
"for fi in (format_info_p3109(3), format_info_p3109(1)):\n",
216216
" print(fi.name)\n",
217217
" for i in (\n",
218218
" 0x00,\n",

src/gfloat/round.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -222,6 +222,6 @@ def encode_float(fi: FormatInfo, v: float) -> int:
222222
isig = (1 << t) - isig
223223

224224
# Pack values into a single integer
225-
ival = (sign << (k - 1)) | (biased_exp << t) | (isig << 0)
225+
code = (sign << (k - 1)) | (biased_exp << t) | (isig << 0)
226226

227-
return ival
227+
return code

src/gfloat/types.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -36,7 +36,7 @@ class FloatValue:
3636
A floating-point value decoded in great detail.
3737
"""
3838

39-
ival: int #: Integer code point
39+
code: int #: Integer code point
4040

4141
#: Value. Assumed to be exactly round-trippable to python float.
4242
#: This is true for all <64bit formats known in 2023.

test/test_decode.py

Lines changed: 13 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -14,8 +14,8 @@ def _isnegzero(x: float) -> bool:
1414

1515
def test_spot_check_ocp_e5m2() -> None:
1616
fi = format_info_ocp_e5m2
17-
dec = lambda ival: decode_float(fi, ival).fval
18-
fclass = lambda ival: decode_float(fi, ival).fclass
17+
dec = lambda code: decode_float(fi, code).fval
18+
fclass = lambda code: decode_float(fi, code).fclass
1919
assert dec(0x01) == 2.0**-16
2020
assert dec(0x40) == 2.0
2121
assert _isnegzero(dec(0x80))
@@ -30,7 +30,7 @@ def test_spot_check_ocp_e5m2() -> None:
3030

3131
def test_spot_check_ocp_e4m3() -> None:
3232
fi = format_info_ocp_e4m3
33-
dec = lambda ival: decode_float(fi, ival).fval
33+
dec = lambda code: decode_float(fi, code).fval
3434

3535
assert dec(0x40) == 2.0
3636
assert dec(0x01) == 2.0**-9
@@ -42,7 +42,7 @@ def test_spot_check_ocp_e4m3() -> None:
4242

4343
def test_spot_check_p3109_p3() -> None:
4444
fi = format_info_p3109(3)
45-
dec = lambda ival: decode_float(fi, ival).fval
45+
dec = lambda code: decode_float(fi, code).fval
4646

4747
assert dec(0x01) == 2.0**-17
4848
assert dec(0x40) == 1.0
@@ -53,7 +53,7 @@ def test_spot_check_p3109_p3() -> None:
5353

5454
def test_spot_check_p3109_p1() -> None:
5555
fi = format_info_p3109(1)
56-
dec = lambda ival: decode_float(fi, ival).fval
56+
dec = lambda code: decode_float(fi, code).fval
5757

5858
assert dec(0x01) == 2.0**-62
5959
assert dec(0x40) == 2.0
@@ -64,7 +64,7 @@ def test_spot_check_p3109_p1() -> None:
6464

6565
def test_spot_check_binary16() -> None:
6666
fi = format_info_binary16
67-
dec = lambda ival: decode_float(fi, ival).fval
67+
dec = lambda code: decode_float(fi, code).fval
6868

6969
assert dec(0x3C00) == 1.0
7070
assert dec(0x3C01) == 1.0 + 2**-10
@@ -78,7 +78,7 @@ def test_spot_check_binary16() -> None:
7878

7979
def test_spot_check_bfloat16() -> None:
8080
fi = format_info_bfloat16
81-
dec = lambda ival: decode_float(fi, ival).fval
81+
dec = lambda code: decode_float(fi, code).fval
8282

8383
assert dec(0x3F80) == 1
8484
assert dec(0x4000) == 2
@@ -92,7 +92,7 @@ def test_spot_check_bfloat16() -> None:
9292
def test_spot_check_ocp_e2m3() -> None:
9393
# Test against Table 4 in "OCP Microscaling Formats (MX) v1.0 Spec"
9494
fi = format_info_ocp_e2m3
95-
dec = lambda ival: decode_float(fi, ival).fval
95+
dec = lambda code: decode_float(fi, code).fval
9696

9797
assert fi.max == 7.5
9898
assert fi.smallest_subnormal == 0.125
@@ -109,7 +109,7 @@ def test_spot_check_ocp_e2m3() -> None:
109109
def test_spot_check_ocp_e3m2() -> None:
110110
# Test against Table 4 in "OCP Microscaling Formats (MX) v1.0 Spec"
111111
fi = format_info_ocp_e3m2
112-
dec = lambda ival: decode_float(fi, ival).fval
112+
dec = lambda code: decode_float(fi, code).fval
113113

114114
assert fi.max == 28.0
115115
assert fi.smallest_subnormal == 0.0625
@@ -126,7 +126,7 @@ def test_spot_check_ocp_e3m2() -> None:
126126
def test_spot_check_ocp_e2m1() -> None:
127127
# Test against Table 5 in "OCP Microscaling Formats (MX) v1.0 Spec"
128128
fi = format_info_ocp_e2m1
129-
dec = lambda ival: decode_float(fi, ival).fval
129+
dec = lambda code: decode_float(fi, code).fval
130130

131131
assert fi.max == 6.0
132132
assert fi.smallest_subnormal == 0.5
@@ -149,8 +149,8 @@ def test_spot_check_ocp_e2m1() -> None:
149149
def test_spot_check_ocp_e8m0() -> None:
150150
# Test against Table 7 in "OCP Microscaling Formats (MX) v1.0 Spec"
151151
fi = format_info_ocp_e8m0
152-
dec = lambda ival: decode_float(fi, ival).fval
153-
fclass = lambda ival: decode_float(fi, ival).fclass
152+
dec = lambda code: decode_float(fi, code).fval
153+
fclass = lambda code: decode_float(fi, code).fclass
154154
assert fi.expBias == 127
155155
assert fi.max == 2.0**127
156156
assert fi.smallest == 2.0**-127
@@ -168,7 +168,7 @@ def test_spot_check_ocp_e8m0() -> None:
168168
def test_spot_check_ocp_int8() -> None:
169169
# Test against Table TODO in "OCP Microscaling Formats (MX) v1.0 Spec"
170170
fi = format_info_ocp_int8
171-
dec = lambda ival: decode_float(fi, ival).fval
171+
dec = lambda code: decode_float(fi, code).fval
172172

173173
assert fi.max == 1.0 + 63.0 / 64
174174
assert fi.smallest == 2.0**-6

test/test_encode.py

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -21,9 +21,9 @@ def test_encode(fi: FormatInfo) -> None:
2121

2222
for i in range(0, 2**fi.bits, step):
2323
fv = decode_float(fi, i)
24-
ival = encode_float(fi, fv.fval)
25-
assert (i == ival) or np.isnan(fv.fval)
26-
fv2 = decode_float(fi, ival)
24+
code = encode_float(fi, fv.fval)
25+
assert (i == code) or np.isnan(fv.fval)
26+
fv2 = decode_float(fi, code)
2727
np.testing.assert_equal(fv2.fval, fv.fval)
2828

2929

0 commit comments

Comments
 (0)