Skip to content

Commit 5e6cca2

Browse files
authored
Merge pull request #22 from graphcore-research/formats-fix
Shorten format names
2 parents b87990d + 8ddfe61 commit 5e6cca2

File tree

2 files changed

+26
-24
lines changed

2 files changed

+26
-24
lines changed

docs/source/01-decode.ipynb

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -45,7 +45,7 @@
4545
{
4646
"data": {
4747
"text/plain": [
48-
"FormatInfo(name='ocp_e5m2', k=8, precision=3, emax=15, has_nz=True, has_infs=True, num_high_nans=3, has_subnormals=True, is_signed=True, is_twos_complement=False)"
48+
"FormatInfo(name='format_info_ocp_e5m2', k=8, precision=3, emax=15, has_nz=True, has_infs=True, num_high_nans=3, has_subnormals=True, is_signed=True, is_twos_complement=False)"
4949
]
5050
},
5151
"execution_count": 2,
@@ -288,6 +288,7 @@
288288
"name": "stdout",
289289
"output_type": "stream",
290290
"text": [
291+
"Format ocp_e4m3 ocp_e5m2 p3109_p3\n",
291292
"Max exponent (emax) 8 15 15\n",
292293
"Exponent bias 7 15 16\n",
293294
"Infinities 0 2 2\n",
@@ -306,6 +307,7 @@
306307
"\n",
307308
"\n",
308309
"for prop, probe in (\n",
310+
" (\"Format \", lambda fi: fi.name.replace(\"format_info_\", \"\")),\n",
309311
" (\"Max exponent (emax) \", lambda fi: fi.emax),\n",
310312
" (\"Exponent bias \", lambda fi: fi.expBias),\n",
311313
" (\"Infinities \", lambda fi: 2 * int(fi.has_infs)),\n",

src/gfloat/formats.py

Lines changed: 23 additions & 23 deletions
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,7 @@
55

66
#: FormatInfo for IEEE-754 Binary32 format
77
format_info_binary32 = FormatInfo(
8-
name="format_info_binary32",
8+
name="binary32",
99
k=32,
1010
precision=24,
1111
emax=127,
@@ -19,7 +19,7 @@
1919

2020
#: FormatInfo for IEEE-754 Binary16 format
2121
format_info_binary16 = FormatInfo(
22-
name="format_info_binary16",
22+
name="binary16",
2323
k=16,
2424
precision=11,
2525
emax=15,
@@ -33,7 +33,7 @@
3333

3434
#: FormatInfo for Google BFloat16 format
3535
format_info_bfloat16 = FormatInfo(
36-
name="format_info_bfloat16",
36+
name="bfloat16",
3737
k=16,
3838
precision=8,
3939
emax=127,
@@ -47,7 +47,7 @@
4747

4848
#: FormatInfo for OCP E5M2 format
4949
format_info_ocp_e5m2 = FormatInfo(
50-
name="format_info_ocp_e5m2",
50+
name="ocp_e5m2",
5151
k=8,
5252
precision=3,
5353
emax=15,
@@ -61,7 +61,7 @@
6161

6262
#: FormatInfo for OCP E4M3 format
6363
format_info_ocp_e4m3 = FormatInfo(
64-
name="format_info_ocp_e4m3",
64+
name="ocp_e4m3",
6565
k=8,
6666
precision=4,
6767
emax=8,
@@ -75,7 +75,7 @@
7575

7676
#: FormatInfo for OCP MX E2M3 format
7777
format_info_ocp_e2m3 = FormatInfo(
78-
name="format_info_ocp_e2m3",
78+
name="ocp_e2m3",
7979
k=6,
8080
precision=4,
8181
emax=2,
@@ -89,7 +89,7 @@
8989

9090
#: FormatInfo for OCP MX E3M2 format
9191
format_info_ocp_e3m2 = FormatInfo(
92-
name="format_info_ocp_e3m2",
92+
name="ocp_e3m2",
9393
k=6,
9494
precision=3,
9595
emax=4,
@@ -103,7 +103,7 @@
103103

104104
#: FormatInfo for OCP MX E2M1 format
105105
format_info_ocp_e2m1 = FormatInfo(
106-
name="format_info_ocp_e2m1",
106+
name="ocp_e2m1",
107107
k=4,
108108
precision=2,
109109
emax=2,
@@ -117,7 +117,7 @@
117117

118118
#: FormatInfo for OCP MX E8M0 format
119119
format_info_ocp_e8m0 = FormatInfo(
120-
name="format_info_ocp_e8m0",
120+
name="ocp_e8m0",
121121
k=8,
122122
precision=1,
123123
emax=127,
@@ -131,7 +131,7 @@
131131

132132
#: FormatInfo for OCP MX INT8 format
133133
format_info_ocp_int8 = FormatInfo(
134-
name="format_info_ocp_int8",
134+
name="ocp_int8",
135135
k=8,
136136
precision=8,
137137
emax=0,
@@ -178,63 +178,63 @@ def format_info_p3109(precision: int) -> FormatInfo:
178178

179179

180180
# Collections of formats
181-
tiny_formats = [
181+
_tiny_formats = [
182182
format_info_ocp_e2m1,
183183
format_info_ocp_e2m3,
184184
format_info_ocp_e3m2,
185185
]
186186

187187
p3109_formats = [format_info_p3109(p) for p in range(1, 7)]
188188

189-
fp8_formats = [
189+
_fp8_formats = [
190190
format_info_ocp_e4m3,
191191
format_info_ocp_e5m2,
192192
*p3109_formats,
193193
]
194194

195-
fp16_formats = [
195+
_fp16_formats = [
196196
format_info_binary16,
197197
format_info_bfloat16,
198198
]
199199

200200
all_formats = [
201201
format_info_ocp_e8m0,
202202
format_info_ocp_int8,
203-
*tiny_formats,
204-
*fp8_formats,
205-
*fp16_formats,
203+
*_tiny_formats,
204+
*_fp8_formats,
205+
*_fp16_formats,
206206
format_info_binary32,
207207
]
208208

209209
# ------
210210
# Block formats
211211

212212
format_info_mxfp8_e5m2 = BlockFormatInfo(
213-
"format_info_mxfp8_e5m2", format_info_ocp_e5m2, 32, format_info_ocp_e8m0
213+
"mxfp8_e5m2", format_info_ocp_e5m2, 32, format_info_ocp_e8m0
214214
)
215215

216216
format_info_mxfp8_e4m3 = BlockFormatInfo(
217-
"format_info_mxfp8_e4m3", format_info_ocp_e4m3, 32, format_info_ocp_e8m0
217+
"mxfp8_e4m3", format_info_ocp_e4m3, 32, format_info_ocp_e8m0
218218
)
219219

220220
format_info_mxfp6_e3m2 = BlockFormatInfo(
221-
"format_info_mxfp6_e3m2", format_info_ocp_e3m2, 32, format_info_ocp_e8m0
221+
"mxfp6_e3m2", format_info_ocp_e3m2, 32, format_info_ocp_e8m0
222222
)
223223

224224
format_info_mxfp6_e2m3 = BlockFormatInfo(
225-
"format_info_mxfp6_e2m3", format_info_ocp_e2m3, 32, format_info_ocp_e8m0
225+
"mxfp6_e2m3", format_info_ocp_e2m3, 32, format_info_ocp_e8m0
226226
)
227227

228228
format_info_mxfp4_e2m1 = BlockFormatInfo(
229-
"format_info_mxfp4_e2m1", format_info_ocp_e2m1, 32, format_info_ocp_e8m0
229+
"mxfp4_e2m1", format_info_ocp_e2m1, 32, format_info_ocp_e8m0
230230
)
231231

232232
format_info_mxfp4_e2m1 = BlockFormatInfo(
233-
"format_info_mxfp4_e2m1", format_info_ocp_e2m1, 32, format_info_ocp_e8m0
233+
"mxfp4_e2m1", format_info_ocp_e2m1, 32, format_info_ocp_e8m0
234234
)
235235

236236
format_info_mxint8 = BlockFormatInfo(
237-
"format_info_mxint8", format_info_ocp_int8, 32, format_info_ocp_e8m0
237+
"mxint8", format_info_ocp_int8, 32, format_info_ocp_e8m0
238238
)
239239

240240
all_block_formats = [

0 commit comments

Comments
 (0)