Non-null shouldn't be stripped by semantic

benjie · benjie · commit 2d8277baefff · 2025-03-18T15:31:42.000Z
diff --git a/__tests__/schema-with-directive-only.test.graphql b/__tests__/schema-with-directive-only.test.graphql
@@ -27,7 +27,7 @@ type Book implements Thing {
   id: ID!
   name: String @semanticNonNull
   description: String
-  # Test that this non-null gets stripped
+  # Test that this non-null is retained
   pages: Int! @semanticNonNull
 }
 
diff --git a/__tests__/schema-with-directive.test.graphql b/__tests__/schema-with-directive.test.graphql
@@ -28,7 +28,7 @@ type Book implements Thing {
   # Test that this semantic-non-null doesn't cause issues
   name: String* @semanticNonNull
   description: String
-  # Test that this non-null gets stripped
+  # Test that this non-null is retained
   pages: Int! @semanticNonNull
 }
 
diff --git a/__tests__/schema.test.graphql b/__tests__/schema.test.graphql
@@ -24,7 +24,7 @@ type Book implements Thing {
   id: ID!
   name: String*
   description: String
-  pages: Int*
+  pages: Int!
 }
 
 type Car implements Thing {
diff --git a/__tests__/snapshots/schema-with-directive-only.nullable.graphql b/__tests__/snapshots/schema-with-directive-only.nullable.graphql
@@ -24,7 +24,7 @@ type Book implements Thing {
   id: ID!
   name: String
   description: String
-  pages: Int
+  pages: Int!
 }
 
 type Car implements Thing {
diff --git a/__tests__/snapshots/schema-with-directive.nullable.graphql b/__tests__/snapshots/schema-with-directive.nullable.graphql
@@ -24,7 +24,7 @@ type Book implements Thing {
   id: ID!
   name: String
   description: String
-  pages: Int
+  pages: Int!
 }
 
 type Car implements Thing {
diff --git a/__tests__/snapshots/schema.nullable.graphql b/__tests__/snapshots/schema.nullable.graphql
@@ -24,7 +24,7 @@ type Book implements Thing {
   id: ID!
   name: String
   description: String
-  pages: Int
+  pages: Int!
 }
 
 type Car implements Thing {

Original file line number	Diff line number	Diff line change
`@@ -27,7 +27,7 @@ type Book implements Thing {`
`27`	`27`	`id: ID!`
`28`	`28`	`name: String @semanticNonNull`
`29`	`29`	`description: String`
`30`		`- # Test that this non-null gets stripped`
	`30`	`+ # Test that this non-null is retained`
`31`	`31`	`pages: Int! @semanticNonNull`
`32`	`32`	`}`
`33`	`33`
Original file line number	Diff line number	Diff line change
`@@ -28,7 +28,7 @@ type Book implements Thing {`
`28`	`28`	`# Test that this semantic-non-null doesn't cause issues`
`29`	`29`	`name: String* @semanticNonNull`
`30`	`30`	`description: String`
`31`		`- # Test that this non-null gets stripped`
	`31`	`+ # Test that this non-null is retained`
`32`	`32`	`pages: Int! @semanticNonNull`
`33`	`33`	`}`
`34`	`34`
Original file line number	Diff line number	Diff line change
`@@ -24,7 +24,7 @@ type Book implements Thing {`
`24`	`24`	`id: ID!`
`25`	`25`	`name: String*`
`26`	`26`	`description: String`
`27`		`- pages: Int*`
	`27`	`+ pages: Int!`
`28`	`28`	`}`
`29`	`29`
`30`	`30`	`type Car implements Thing {`