Fix issue with Postgres Docker image requiring POSTGRES_PASSWORD envvar

Author: benjie

docker-compose.yml

@@ -112,6 +112,8 @@ services:
   # This runs the database that everything else connects to
   db:
     image: postgres:11
+    env_file:
+      - .env
 
     # Unlike above, the Postgres image cannot start as our user account
     # otherwise we get permission denied errors. So this one has to run as
@@ -129,7 +131,10 @@ services:
     restart: unless-stopped
     networks:
       - default
-    command: postgres -c logging_collector=on -c log_destination=stderr -c log_directory=/var/lib/postgresql/data/logs -c log_rotation_age=60 -c log_truncate_on_rotation=on -c log_filename=server_log.hour.%H%M
+    command:
+      postgres -c logging_collector=on -c log_destination=stderr -c
+      log_directory=/var/lib/postgresql/data/logs -c log_rotation_age=60 -c
+      log_truncate_on_rotation=on -c log_filename=server_log.hour.%H%M
 
 networks:
   default:

docker/docker.env

@@ -7,9 +7,6 @@ FORCE_COLOR=2
 # `.gmrc` checks for interactive TTY.
 PG_DUMP=docker-compose exec -T db pg_dump
 
-# Instructs to use our docker PostgreSQL service.
-DATABASE_HOST=db
-ROOT_DATABASE_URL=postgres://postgres@db/template1
 
 # Drops tables without asking in `yarn setup`. Reasoning: 1) docker-compose is
 # not tty, 2) it's a dev env anyway.

docker/scripts/yarn-setup.js

@@ -1,6 +1,10 @@
 const { spawnSync: baseSpawnSync } = require("child_process");
 const { basename, dirname, resolve } = require("path");
 const platform = require("os").platform();
+const { safeRandomString } = require("../../scripts/lib/random");
+const fsp = require("fs").promises;
+
+const DOTENV_PATH = `${__dirname}/../../.env`;
 
 if (platform !== "win32" && !process.env.UID) {
   console.error(
@@ -23,28 +27,65 @@ function spawnSync(command, args, options = {}) {
   }
 }
 
-// The `docker-compose` project name defaults to the directory name containing
-// `docker-compose.yml`, which is the root folder of our project. Let's call
-// that 'ROOT'. We're in ROOT/docker/scripts and we want to get the name of
-// ROOT:
-const projectName = basename(dirname(dirname(resolve(__dirname))));
-
-// On Windows we must run 'yarn.cmd' rather than 'yarn'
-const yarnCmd = platform === "win32" ? "yarn.cmd" : "yarn";
-
-spawnSync(yarnCmd, ["down"]);
-spawnSync(yarnCmd, ["db:up"]);
-
-// Fix permissions
-spawnSync(yarnCmd, [
-  "compose",
-  "run",
-  "server",
-  "sudo",
-  "bash",
-  "-c",
-  "chmod o+rwx /var/run/docker.sock && chown -R node /work/node_modules /work/@app/*/node_modules",
-]);
-
-// Run setup as normal
-spawnSync(yarnCmd, ["compose", "run", "server", "yarn", "setup", projectName]);
+async function main() {
+  // POSTGRES_PASSWORD must be set for the Docker Postgres image to boot
+  let data;
+  try {
+    data = await fsp.readFile(DOTENV_PATH, "utf8");
+  } catch (e) {
+    data = "";
+  }
+  if (!data.includes("POSTGRES_PASSWORD=")) {
+    // We cannot use `dotenv` here because we exist outside of Docker, and we
+    // don't have the module installed yet.
+    const password = safeRandomString(30);
+    data += `
+# POSTGRES_PASSWORD is the superuser password for PostgreSQL, it's required to
+# initialize the Postgres docker volume.
+POSTGRES_PASSWORD=${password}
+
+# We're accessing Postgres via Docker:
+DATABASE_HOST=db
+ROOT_DATABASE_URL=postgres://postgres:${password}@db/template1
+`;
+    await fsp.writeFile(DOTENV_PATH, data);
+  }
+
+  // The `docker-compose` project name defaults to the directory name containing
+  // `docker-compose.yml`, which is the root folder of our project. Let's call
+  // that 'ROOT'. We're in ROOT/docker/scripts and we want to get the name of
+  // ROOT:
+  const projectName = basename(dirname(dirname(resolve(__dirname))));
+
+  // On Windows we must run 'yarn.cmd' rather than 'yarn'
+  const yarnCmd = platform === "win32" ? "yarn.cmd" : "yarn";
+
+  spawnSync(yarnCmd, ["down"]);
+  spawnSync(yarnCmd, ["db:up"]);
+
+  // Fix permissions
+  spawnSync(yarnCmd, [
+    "compose",
+    "run",
+    "server",
+    "sudo",
+    "bash",
+    "-c",
+    "chmod o+rwx /var/run/docker.sock && chown -R node /work/node_modules /work/@app/*/node_modules",
+  ]);
+
+  // Run setup as normal
+  spawnSync(yarnCmd, [
+    "compose",
+    "run",
+    "server",
+    "yarn",
+    "setup",
+    projectName,
+  ]);
+}
+
+main().catch(e => {
+  console.error(e);
+  process.exit(1);
+});