Skip to content

Commit 037cf42

Browse files
author
Lee Richmond
committed
Lock version of jsonapi-renderer
Per Slack: Tom Luce [12:08 PM] One thing I did find today @richmolj is that I believe that the latest version of the jsonapi-renderer gem (0.2.1) introduces a breaking change. Specifically: When including resources that have an underscore in their name (e.g. careers_pages/1?include=careers_pages_blocks) the renderer now throws an InvalidKey error because the name doesn't match a regex they've introduced. It's not an issue with Graphiti per-say but I thought i'd flag it as something worth noting because i've burnt some time getting to the bottom of it. I'll have to raise a separate issue on the renderer gem to change the regex to allow underscores, but in the meantime locking the version to 0.2.0 is the only way to get Graphiti to work properly! (edited) If you're interested you can see the change here -> jsonapi-rb/jsonapi-renderer@v0.2.0...v0.2.1
1 parent 6e87d5e commit 037cf42

File tree

2 files changed

+2
-1
lines changed

2 files changed

+2
-1
lines changed

graphiti.gemspec

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -19,6 +19,7 @@ Gem::Specification.new do |spec|
1919
spec.required_ruby_version = "~> 2.3"
2020

2121
spec.add_dependency "jsonapi-serializable", "~> 0.3.0"
22+
spec.add_dependency "jsonapi-renderer", "0.2.0"
2223
spec.add_dependency "dry-types", "~> 0.15"
2324
spec.add_dependency "graphiti_errors", "~> 1.1.0"
2425
spec.add_dependency "concurrent-ruby", "~> 1.0"

lib/graphiti/version.rb

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,3 @@
11
module Graphiti
2-
VERSION = "1.2.1"
2+
VERSION = "1.2.2"
33
end

0 commit comments

Comments
 (0)