Don't blow up when missing/unexpected context

Author: Lee Richmond

lib/graphiti/sideload.rb

@@ -137,11 +137,16 @@ def link_filter(parents)
     end
 
     def link_extra_fields
+      return unless context&.respond_to?(:params)
+
       extra_fields_name = [association_name, resource.type].find { |param|
         context.params.dig(:extra_fields, param)
       }
 
-      {resource.type => context.params.dig(:extra_fields, extra_fields_name)} if extra_fields_name
+      if extra_fields_name
+        extra_fields = context.params.dig(:extra_fields, extra_fields_name)
+        {resource.type => extra_fields}
+      end
     end
 
     # The parent resource is a remote,

lib/graphiti/version.rb

@@ -1,3 +1,3 @@
 module Graphiti
-  VERSION = "1.2.39"
+  VERSION = "1.2.40"
 end

spec/extra_fields_spec.rb

@@ -29,6 +29,45 @@ def attributes
       .to match_array(%w[first_name last_name age stack_ranking])
   end
 
+  context "when sideloading/linking" do
+    before do
+      allow_any_instance_of(PORO::Employee)
+        .to receive(:linked_positions) { [] }
+      resource.has_many :linked_positions,
+        resource: PORO::PositionResource,
+        link: true
+      params[:include] = "linked_positions"
+    end
+
+    context "and the context is missing" do
+      around do |e|
+        Graphiti.with_context nil do
+          e.run
+        end
+      end
+
+      it "does not blow up" do
+        params[:extra_fields] = {positions: "foo"}
+        expect { render }.to_not raise_error
+      end
+    end
+
+    context "and the context does not respond to params" do
+      around do |e|
+        # current_user referenced in resource fixtures
+        ctx = Struct.new(:current_user).new
+        Graphiti.with_context ctx do
+          e.run
+        end
+      end
+
+      it "does not blow up" do
+        params[:extra_fields] = {positions: "foo"}
+        expect { render }.to_not raise_error
+      end
+    end
+  end
+
   context "when multiple extra attributes" do
     context "added with blocks" do
       before do