Remove action, controller, format query parameters from page links

Author: gfmurphy

lib/graphiti/delegates/pagination.rb

@@ -20,13 +20,17 @@ def links
 
       private
 
+      def pagination_params
+        @pagination_params ||= @proxy.query.params.reject { |k, _| [:action, :controller, :format].include?(k) }
+      end
+
       def pagination_link(page)
         return nil unless @proxy.resource.endpoint
 
         uri = URI(@proxy.resource.endpoint[:url].to_s)
 
         # Overwrite the pagination query params with the desired page
-        uri.query = @proxy.query.params.merge({
+        uri.query = pagination_params.merge({
           page: {
             number: page,
             size: page_size

spec/delegates/pagination_spec.rb

@@ -59,13 +59,26 @@
         {include: "bar,bazzes", filter: {"bazzes.deprecated" => "foo"}}
       }
 
-      it "is preserved correctly" do
+      it "preserves include directive and filters on relationships" do
         query = URI.decode_www_form(URI(subject[:first]).query).to_h
         expect(query["include"]).to include("bar")
         expect(query["include"]).to include("bazzes")
         expect(query["filter[bazzes.deprecated]"]).to eq("foo")
       end
     end
+
+    context "with rails parameters" do
+      let(:params) {
+        {controller: "foos", action: "index", format: "jsonapi"}
+      }
+
+      it "removes them" do
+        page_links = subject.values
+        expect(page_links).to all(satisfy { |v| v["controller=foos"].nil? })
+        expect(page_links).to all(satisfy { |v| v["action=index"].nil? })
+        expect(page_links).to all(satisfy { |v| v["format=jsonapi"].nil? })
+      end
+    end
   end
 
   def pagination_link(number, size: current_per_page)