Skip to content

Commit c94cd33

Browse files
authored
fix: sort types in generated schema (#407)
Otherwise, added types order may depend on file load order which is not always deterministic if the files don't depend on each other.
1 parent d3e09c2 commit c94cd33

File tree

2 files changed

+5
-1
lines changed

2 files changed

+5
-1
lines changed

lib/graphiti/schema.rb

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -42,7 +42,7 @@ def generate
4242

4343
def generate_types
4444
{}.tap do |types|
45-
Graphiti::Types.map.each_pair do |name, config|
45+
Graphiti::Types.map.sort.each_entry do |name, config|
4646
types[name] = config.slice(:kind, :description)
4747
end
4848
end

spec/schema_spec.rb

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -244,6 +244,10 @@ def self.name
244244
expect(schema[:types]).to eq(expected[:types])
245245
end
246246

247+
it "has sorted types" do
248+
expect(schema[:types].to_a).to eq(expected[:types].sort)
249+
end
250+
247251
# Dynamically-created resources, e.g. remote resources
248252
context "when resource has missing name" do
249253
let(:no_name) do

0 commit comments

Comments
 (0)