Merge pull request #197 from richmolj/master

Bypass required filters on .find

Author: wadetandy

lib/graphiti/resource/interface.rb

@@ -28,7 +28,10 @@ def _find(params = {}, base_scope = nil)
           params[:filter][:id] = id if id
 
           runner = Runner.new(self, params)
-          runner.proxy(base_scope, single: true, raise_on_missing: true)
+          runner.proxy base_scope,
+            single: true,
+            raise_on_missing: true,
+            bypass_required_filters: true
         end
 
         def build(params, base_scope = nil)

lib/graphiti/runner.rb

@@ -63,7 +63,8 @@ def proxy(base = nil, opts = {})
         :after_resolve,
         :sideload,
         :parent,
-        :params
+        :params,
+        :bypass_required_filters
       scope = jsonapi_scope(base, scope_opts)
       ResourceProxy.new jsonapi_resource,
         scope,

lib/graphiti/scoping/filter.rb

@@ -3,7 +3,7 @@ class Scoping::Filter < Scoping::Base
     include Scoping::Filterable
 
     def apply
-      if missing_required_filters.any?
+      if missing_required_filters.any? && !@opts[:bypass_required_filters]
         raise Errors::RequiredFilter.new(resource, missing_required_filters)
       end
 

spec/filtering_spec.rb

@@ -1702,6 +1702,19 @@ def admin?
           records
         }.to raise_error(Graphiti::Errors::RequiredFilter)
       end
+
+      context 'because it came from .find' do
+        before do
+          resource.filter :id, :integer
+        end
+
+        it 'does not require the filter' do
+          expect {
+            proxy = resource.find(filter: { id: employee2.id })
+            expect(proxy.data.id).to eq(employee2.id)
+          }.to_not raise_error
+        end
+      end
     end
   end