Simplify checking for cycles

clue · clue · commit 72ea516edc63 · 2013-07-12T23:28:01.000+02:00
diff --git a/src/Property/WalkProperty.php b/src/Property/WalkProperty.php
@@ -61,8 +61,8 @@ public function __construct(Walk $walk)
      */
     public function isCycle()
     {
-        $vertices = $this->walk->getVertices()->getVector();
-        return (reset($vertices) === end($vertices) && !$this->walk->getEdges()->isEmpty());
+        $vertices = $this->walk->getVertices();
+        return ($vertices->getVertexFirst() === $vertices->getVertexLast() && !$this->walk->getEdges()->isEmpty());
     }
 
     /**

Original file line number	Diff line number	Diff line change
`@@ -61,8 +61,8 @@ public function __construct(Walk $walk)`
`61`	`61`	`*/`
`62`	`62`	`public function isCycle()`
`63`	`63`	`{`
`64`		`- $vertices = $this->walk->getVertices()->getVector();`
`65`		`- return (reset($vertices) === end($vertices) && !$this->walk->getEdges()->isEmpty());`
	`64`	`+ $vertices = $this->walk->getVertices();`
	`65`	`+ return ($vertices->getVertexFirst() === $vertices->getVertexLast() && !$this->walk->getEdges()->isEmpty());`
`66`	`66`	`}`
`67`	`67`
`68`	`68`	`/**`