Tests for parallel/loop/undirected edges (100% coverage)

Author: clue

tests/Tree/BaseDirectedTest.php

@@ -13,6 +13,8 @@ abstract protected function createGraphNonTree();
 
     abstract protected function createGraphTree();
 
+    abstract protected function createGraphParallelEdge();
+
     public function testEmptyGraph()
     {
         $graph = new Graph();
@@ -69,11 +71,15 @@ public function testGraphTree()
 
         $this->assertTrue($tree->isTree());
         $this->assertSame($root, $tree->getVertexRoot());
+        $this->assertSame(array_values($graph->getVertices()), array_values($tree->getVerticesSubtree($root)));
         $this->assertSame(array_values($nonRoot), array_values($tree->getVerticesChildren($root)));
+        $this->assertSame(array_values($nonRoot), array_values($tree->getVerticesDescendant($root)));
         $this->assertSame(array_values($nonRoot), array_values($tree->getVerticesLeaf()));
         $this->assertSame(array(), array_values($tree->getVerticesInternal()));
         $this->assertSame($root, $tree->getVertexParent($c1));
         $this->assertSame(array(), $tree->getVerticesChildren($c1));
+        $this->assertSame(array(), $tree->getVerticesDescendant($c1));
+        $this->assertSame(array($c1), array_values($tree->getVerticesSubtree($c1)));
         $this->assertEquals(2, $tree->getDegree());
         $this->assertEquals(0, $tree->getDepthVertex($root));
         $this->assertEquals(1, $tree->getDepthVertex($c1));
@@ -116,4 +122,62 @@ public function testNonTreeVertexHasMoreThanOneParent()
 
         $tree->getVertexParent($graph->getVertex('v3'));
     }
+
+    public function testGraphWithParallelEdgeIsNotTree()
+    {
+        $graph = $this->createGraphParallelEdge();
+
+        $tree = $this->createTreeAlg($graph);
+
+        $this->assertFalse($tree->isTree());
+    }
+
+    public function testGraphWithLoopIsNotTree()
+    {
+        // v1 -> v1
+        $graph = new Graph();
+        $graph->createVertex('v1')->createEdgeTo($graph->getVertex('v1'));
+
+        $tree = $this->createTreeAlg($graph);
+
+        $this->assertFalse($tree->isTree());
+    }
+
+    /**
+     * @expectedException UnexpectedValueException
+     */
+    public function testGraphWithLoopCanNotGetSubgraph()
+    {
+        // v1 -> v1
+        $graph = new Graph();
+        $graph->createVertex('v1')->createEdgeTo($graph->getVertex('v1'));
+
+        $tree = $this->createTreeAlg($graph);
+
+        $tree->getVerticesSubtree($graph->getVertex('v1'));
+    }
+
+    public function testGraphWithUndirectedEdgeIsNotTree()
+    {
+        // v1 -- v2
+        $graph = new Graph();
+        $graph->createVertex('v1')->createEdge($graph->createVertex('v2'));
+
+        $tree = $this->createTreeAlg($graph);
+
+        $this->assertFalse($tree->isTree());
+    }
+
+    public function testGraphWithMixedEdgesIsNotTree()
+    {
+        // v1 -> v2 -- v3 -> v4
+        $graph = new Graph();
+        $graph->createVertex('v1')->createEdgeTo($graph->createVertex('v2'));
+        $graph->getVertex('v2')->createEdge($graph->createVertex('v3'));
+        $graph->getVertex('v3')->createEdgeTo($graph->createVertex('v4'));
+
+        $tree = $this->createTreeAlg($graph);
+
+        $this->assertFalse($tree->isTree());
+    }
 }

tests/Tree/InTreeTest.php

@@ -35,4 +35,14 @@ protected function createGraphNonTree()
 
         return $graph;
     }
+
+    protected function createGraphParallelEdge()
+    {
+        // v1 <- v2, v1 <- v2
+        $graph = new Graph();
+        $graph->createVertex('v2')->createEdgeTo($graph->createVertex('v1'));
+        $graph->getVertex('v2')->createEdgeTo($graph->getVertex('v1'));
+
+        return $graph;
+    }
 }

tests/Tree/OutTreeTest.php

@@ -35,4 +35,14 @@ protected function createGraphNonTree()
 
         return $graph;
     }
+
+    protected function createGraphParallelEdge()
+    {
+        // v1 -> v2, v1 -> v2
+        $graph = new Graph();
+        $graph->createVertex('v1')->createEdgeTo($graph->createVertex('v2'));
+        $graph->getVertex('v1')->createEdgeTo($graph->getVertex('v2'));
+
+        return $graph;
+    }
 }