Remove unneeded methods getVerticesIds() and getVerticesId()

Author: clue

src/ConnectedComponents.php

@@ -18,7 +18,7 @@ class ConnectedComponents extends BaseGraph
      * @param  Vertex                   $vertex
      * @return Graph
      * @throws InvalidArgumentException if given vertex is not from same graph
-     * @uses AlgorithmSearchBreadthFirst::getVerticesIds()
+     * @uses AlgorithmSearchBreadthFirst::getVertices()
      * @uses Graph::createGraphCloneVertices()
      */
     public function createGraphComponentVertex(Vertex $vertex)
@@ -30,6 +30,11 @@ public function createGraphComponentVertex(Vertex $vertex)
         return $this->graph->createGraphCloneVertices($this->createSearch($vertex)->getVertices());
     }
 
+    /**
+     *
+     * @param Vertex $vertex
+     * @return SearchBreadthFirst
+     */
     private function createSearch(Vertex $vertex)
     {
         $alg = new SearchBreadthFirst($vertex);
@@ -58,7 +63,7 @@ public function isSingle()
     /**
      * @return int number of components
      * @uses Graph::getVertices()
-     * @uses AlgorithmSearchBreadthFirst::getVerticesIds()
+     * @uses AlgorithmSearchBreadthFirst::getVertices()
      */
     public function getNumberOfComponents()
     {
@@ -71,7 +76,7 @@ public function getNumberOfComponents()
             if (!isset($visitedVertices[$vid])) {
 
                 // get all vertices of this component
-                $newVertices = $this->createSearch($vertex)->getVerticesIds();
+                $newVertices = $this->createSearch($vertex)->getVertices()->getIds();
 
                 ++$components;
 

src/DetectNegativeCycle.php

@@ -36,7 +36,7 @@ public function hasCycleNegative()
      *
      * @return Cycle
      * @throws UnderflowException if there's no negative cycle
-     * @uses AlgorithmSpMooreBellmanFord::getVerticesId()
+     * @uses AlgorithmSpMooreBellmanFord::getVertices()
      */
     public function getCycleNegative()
     {
@@ -51,7 +51,7 @@ public function getCycleNegative()
 
                 try {
                     // try to get all connected vertices (or throw new cycle)
-                    foreach ($alg->getVerticesId() as $vid) {
+                    foreach ($alg->getVertices()->getIds() as $vid) {
                         // getting connected vertices succeeded, so skip over all of them
                         $verticesVisited[$vid] = true;
                     // no cycle found, check next vertex...

src/MinimumSpanningTree/Kruskal.php

@@ -78,9 +78,10 @@ public function getEdges()
         // Füge billigste Kanten zu neuen Graphen hinzu und verschmelze teilgragen wenn es nötig ist (keine Kreise)
         // solange ich mehr als einen Graphen habe mit weniger als n-1 kanten (bei n knoten im original)
         foreach ($sortedEdges as $edge) {
+            /* @var $edge EdgeDirected */
             // Gucke Kante an:
 
-            $vertices = $edge->getVerticesId();
+            $vertices = $edge->getVertices()->getIds();
 
             $aId = $vertices[0];
             $bId = $vertices[1];

src/Search/Base.php

@@ -64,15 +64,4 @@ public function getNumberOfVertices()
      * @return Vertices
      */
     abstract public function getVertices();
-
-    /**
-     * get array of all vertices' IDs that can be reached from start vertex
-     *
-     * @return int[]
-     * @uses AlgorithmSearch::getVertices()
-     */
-    public function getVerticesIds()
-    {
-        return $this->getVertices()->getIds();
-    }
 }

src/ShortestPath/Base.php

@@ -110,17 +110,6 @@ public function getVertices()
         return new Vertices($vertices);
     }
 
-    /**
-     * get array of all vertices' IDs the given start vertex has a path to
-     *
-     * @return int[]
-     * @uses AlgorithmSp::getDistanceMap()
-     */
-    public function getVerticesId()
-    {
-        return array_keys($this->getDistanceMap());
-    }
-
     /**
      * get map of vertex IDs to distance
      *