Merge pull request #937 from graphprotocol/mde/pr937-fix-oz-n-01

fix: change OracleVote event order (OZ N-01)

Author: Maikol

packages/contracts/contracts/rewards/SubgraphAvailabilityManager.sol

@@ -210,12 +210,12 @@ contract SubgraphAvailabilityManager is Governed {
             : lastAllowVote[currentNonce][_subgraphDeploymentID];
         lastVoteForSubgraph[_oracleIndex] = timestamp;
 
+        emit OracleVote(_subgraphDeploymentID, _deny, _oracleIndex, timestamp);
+
         // check if execution threshold is reached, if it is call the RewardsManager
         if (checkVotes(_subgraphDeploymentID, _deny)) {
             rewardsManager.setDenied(_subgraphDeploymentID, _deny);
         }
-
-        emit OracleVote(_subgraphDeploymentID, _deny, _oracleIndex, timestamp);
     }
 
     /**

packages/contracts/test/rewards/subgraphAvailability.test.ts

@@ -283,6 +283,12 @@ describe('SubgraphAvailabilityManager', () => {
         .to.emit(rewardsManager, 'RewardsDenylistUpdated')
         .withArgs(subgraphDeploymentID1, tx.blockNumber)
 
+      // check events order
+      const receipt = await tx.wait()
+      expect(receipt.events[0].event).to.be.equal('OracleVote')
+      const rewardsManangerEvent = rewardsManager.interface.parseLog(receipt.logs[1]).name
+      expect(rewardsManangerEvent).to.be.equal('RewardsDenylistUpdated')
+
       // check that subgraph is denied
       expect(await rewardsManager.isDenied(subgraphDeploymentID1)).to.be.true